linux-kernel - Re: [PATCH 1/1] x86/platform/UV: Fix critical UV MMR address error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 28 Mar 2018 20:17:17 +0200 (CEST)
From:   Thomas Gleixner <tglx@...utronix.de>
To:     mike.travis@....com
cc:     Ingo Molnar <mingo@...hat.com>,
        Russ Anderson <russ.anderson@....com>,
        Dimitri Sivanich <dimitri.sivanich@....com>,
        Andrew Banman <andrew.banman@....com>, x86@...nel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/1] x86/platform/UV: Fix critical UV MMR address error

On Wed, 28 Mar 2018, mike.travis@....com wrote:

> A critical error was found testing the fixed UV4 HUB in that an MMR
> address was found to be incorrect.  This causes the virtual address
> space for accessing the MMIOH1 region to be allocated with the
> incorrect size.

Even if this is not intended for stable, despite the diff 

> --- linux-4.4.orig/arch/x86/include/asm/uv/uv_mmrs.h
> +++ linux-4.4/arch/x86/include/asm/uv/uv_mmrs.h

suggesting that this is against a kernel, which receives respiration
treatment, it would be appreciated if you could add a Fixes tag next time.

That spares me the time to figure out which commit introduced the wreckage
and therefore the scope of the fix. Added it myself.

Thanks,

	tglx

> @@ -3833,7 +3833,7 @@ union uvh_rh_gam_mmioh_overlay_config0_m
>  #define UV1H_RH_GAM_MMIOH_OVERLAY_CONFIG1_MMR uv_undefined("UV1H_RH_GAM_MMIOH_OVERLAY_CONFIG1_MMR")
>  #define UV2H_RH_GAM_MMIOH_OVERLAY_CONFIG1_MMR uv_undefined("UV2H_RH_GAM_MMIOH_OVERLAY_CONFIG1_MMR")
>  #define UV3H_RH_GAM_MMIOH_OVERLAY_CONFIG1_MMR 0x1603000UL
> -#define UV4H_RH_GAM_MMIOH_OVERLAY_CONFIG1_MMR 0x483000UL
> +#define UV4H_RH_GAM_MMIOH_OVERLAY_CONFIG1_MMR 0x484000UL
>  #define UVH_RH_GAM_MMIOH_OVERLAY_CONFIG1_MMR (				\
>  	is_uv1_hub() ? UV1H_RH_GAM_MMIOH_OVERLAY_CONFIG1_MMR :		\
>  	is_uv2_hub() ? UV2H_RH_GAM_MMIOH_OVERLAY_CONFIG1_MMR :		\
> 
> -- 
>