linux-kernel - Re: [pci PATCH v7 2/5] virtio_pci: Add support for unmanaged SR-IOV on virtio

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <52734805-4A20-41C0-A46A-A8AFF8D79A72@intel.com>
Date:   Wed, 28 Mar 2018 21:31:40 +0000
From:   "Rustad, Mark D" <mark.d.rustad@...el.com>
To:     Alexander Duyck <alexander.duyck@...il.com>
CC:     "bhelgaas@...gle.com" <bhelgaas@...gle.com>,
        "Duyck, Alexander H" <alexander.h.duyck@...el.com>,
        "linux-pci@...r.kernel.org" <linux-pci@...r.kernel.org>,
        "virtio-dev@...ts.oasis-open.org" <virtio-dev@...ts.oasis-open.org>,
        "kvm@...r.kernel.org" <kvm@...r.kernel.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "Daly, Dan" <dan.daly@...el.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-nvme@...ts.infradead.org" <linux-nvme@...ts.infradead.org>,
        "Busch, Keith" <keith.busch@...el.com>,
        "netanel@...zon.com" <netanel@...zon.com>,
        "ddutile@...hat.com" <ddutile@...hat.com>,
        "mheyne@...zon.de" <mheyne@...zon.de>,
        "Wang, Liang-min" <liang-min.wang@...el.com>,
        "dwmw2@...radead.org" <dwmw2@...radead.org>,
        "hch@....de" <hch@....de>, "dwmw@...zon.co.uk" <dwmw@...zon.co.uk>
Subject: Re: [pci PATCH v7 2/5] virtio_pci: Add support for unmanaged SR-IOV
 on virtio_pci devices

On Mar 15, 2018, at 11:42 AM, Alexander Duyck <alexander.duyck@...il.com> wrote:

> From: Alexander Duyck <alexander.h.duyck@...el.com>
> 
> Hardware-realized virtio_pci devices can implement SR-IOV, so this
> patch enables its use. The device in question is an upcoming Intel
> NIC that implements both a virtio_net PF and virtio_net VFs. These
> are hardware realizations of what has been up to now been a software
> interface.
> 
> The device in question has the following 4-part PCI IDs:
> 
> PF: vendor: 1af4 device: 1041 subvendor: 8086 subdevice: 15fe
> VF: vendor: 1af4 device: 1041 subvendor: 8086 subdevice: 05fe
> 
> The patch currently needs no check for device ID, because the callback
> will never be made for devices that do not assert the capability or
> when run on a platform incapable of SR-IOV.
> 
> One reason for this patch is because the hardware requires the
> vendor ID of a VF to be the same as the vendor ID of the PF that
> created it. So it seemed logical to simply have a fully-functioning
> virtio_net PF create the VFs. This patch makes that possible.
> 
> Reviewed-by: Christoph Hellwig <hch@....de>
> Signed-off-by: Mark Rustad <mark.d.rustad@...el.com>
> Signed-off-by: Alexander Duyck <alexander.h.duyck@...el.com>
> ---
> 
> v4: Dropped call to pci_disable_sriov in virtio_pci_remove function
> v5: Replaced call to pci_sriov_configure_unmanaged with
>         pci_sriov_configure_simple
> v6: Dropped "#ifdef" checks for IOV wrapping sriov_configure definition
> v7: No code change, added Reviewed-by
> 
>  drivers/virtio/virtio_pci_common.c |    1 +
>  1 file changed, 1 insertion(+)

Tested with the identified device.

Tested-by: Mark Rustad <mark.d.rustad@...el.com>

--
Mark Rustad, Networking Division, Intel Corporation

Download attachment "signature.asc" of type "application/pgp-signature" (874 bytes)