linux-kernel - RE: [PATCH] scsi: devinfo: Add Microsoft iSCSI target to 1024 sector blacklist

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <MWHPR2101MB0729E7680EDB0EE4886AAED1CEA30@MWHPR2101MB0729.namprd21.prod.outlook.com>
Date:   Wed, 28 Mar 2018 22:33:05 +0000
From:   Long Li <longli@...rosoft.com>
To:     "Martin K. Petersen" <martin.petersen@...cle.com>,
        KY Srinivasan <kys@...rosoft.com>
CC:     Ross Lagerwall <ross.lagerwall@...rix.com>,
        "James E.J. Bottomley" <jejb@...ux.vnet.ibm.com>,
        "linux-scsi@...r.kernel.org" <linux-scsi@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH] scsi: devinfo: Add Microsoft iSCSI target to 1024 sector
 blacklist

> Subject: Re: [PATCH] scsi: devinfo: Add Microsoft iSCSI target to 1024 sector
> blacklist
> 
> 
> Long, KY: Please confirm.
> 
> > The Windows Server 2016 iSCSI target doesn't work with the Linux
> > kernel initiator since the kernel started sending larger requests by
> > default, nor does it implement the block limits VPD page. Apply the
> > sector limit workaround for these targets.
> >
> > Signed-off-by: Ross Lagerwall <ross.lagerwall@...rix.com>
> > ---
> >  drivers/scsi/scsi_devinfo.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/scsi/scsi_devinfo.c b/drivers/scsi/scsi_devinfo.c
> > index f3b1172..5cb748a 100644
> > --- a/drivers/scsi/scsi_devinfo.c
> > +++ b/drivers/scsi/scsi_devinfo.c
> > @@ -213,7 +213,7 @@ static struct {
> >  	{"Medion", "Flash XL  MMC/SD", "2.6D", BLIST_FORCELUN},
> >  	{"MegaRAID", "LD", NULL, BLIST_FORCELUN},
> >  	{"MICROP", "4110", NULL, BLIST_NOTQ},
> > -	{"MSFT", "Virtual HD", NULL, BLIST_NO_RSOC},
> > +	{"MSFT", "Virtual HD", NULL, BLIST_MAX_1024 | BLIST_NO_RSOC},

Ross,

What about storage_channel_properties.max_transfer_bytes returned from VSTOR_OPERATION_QUERY_PROPERTIES (in storvsc_channel_init())

Does it return correctly the maximum transfer size for iSCSI?

Long 

> >  	{"MYLEX", "DACARMRB", "*", BLIST_REPORTLUN2},
> >  	{"nCipher", "Fastness Crypto", NULL, BLIST_FORCELUN},
> >  	{"NAKAMICH", "MJ-4.8S", NULL, BLIST_FORCELUN |
> BLIST_SINGLELUN},
> 
> --
> Martin K. Petersen	Oracle Linux Engineering