linux-kernel - Re: [PATCH v2] pcm_native: Remove VLA usage

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f9720994-b65b-bbf8-334c-a6643b98c131@sakamocchi.jp>
Date:   Thu, 29 Mar 2018 08:42:57 +0900
From:   Takashi Sakamoto <o-takashi@...amocchi.jp>
To:     Kyle Spiers <kyle@...ers.me>, perex@...ex.cz
Cc:     tiwai@...e.com, alsa-devel@...a-project.org,
        linux-kernel@...r.kernel.org, keescook@...omium.org
Subject: Re: [PATCH v2] pcm_native: Remove VLA usage

Hi,

On Mar 29 2018 07:24, Kyle Spiers wrote:
> As part of the effort to remove VLAs from the kernel[1], this changes
> the allocation of the rstamps array from being on the stack to being
> kcalloc()ed. This also allows for the removal of the explicit zeroing
> loop.
> 
> Signed-off-by: Kyle Spiers <kyle@...ers.me>
> ---
>   sound/core/pcm_native.c | 11 +++++++----
>   1 file changed, 7 insertions(+), 4 deletions(-)

This bug was already fixed at a commit 5730f9f744cf ('
ALSA: pcm: Remove VLA usage')[1][2].

[1] 
https://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound.git/commit/sound/core/pcm_native.c?h=for-next&id=5730f9f744cfe20b771adc33f3b476b95d3eebba
[2] 
http://mailman.alsa-project.org/pipermail/alsa-devel/2018-March/133268.html


Thanks

Takashi Sakamoto