linux-kernel - Re: [PATCH v4 1/3] Add notrace to lib/ucmpdi2.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <mhng-e7e3dffe-bc80-4bea-8cf5-4d8afb76565a@palmer-si-x1c4>
Date:   Thu, 29 Mar 2018 14:59:20 -0700 (PDT)
From:   Palmer Dabbelt <palmer@...ive.com>
To:     matt.redfearn@...s.com
CC:     antonynpavlov@...il.com, jhogan@...nel.org, ralf@...ux-mips.org,
        linux-mips@...ux-mips.org, matt.redfearn@...s.com,
        geert@...ux-m68k.org, linux-kernel@...r.kernel.org
Subject:     Re: [PATCH v4 1/3] Add notrace to lib/ucmpdi2.c

On Thu, 29 Mar 2018 03:41:21 PDT (-0700), matt.redfearn@...s.com wrote:
> From: Palmer Dabbelt <palmer@...ive.com>
>
> As part of the MIPS conversion to use the generic GCC library routines,
> Matt Redfearn discovered that I'd missed a notrace on __ucmpdi2().  This
> patch rectifies the problem.
>
> CC: Matt Redfearn <matt.redfearn@...s.com>
> CC: Antony Pavlov <antonynpavlov@...il.com>
> Signed-off-by: Palmer Dabbelt <palmer@...ive.com>
> Reviewed-by: Matt Redfearn <matt.redfearn@...s.com>
> Signed-off-by: Matt Redfearn <matt.redfearn@...s.com>
> ---
>
> Changes in v4: None
> Changes in v3: None
> Changes in v2:
>   add notrace to lib/ucmpdi2.c
>
>  lib/ucmpdi2.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lib/ucmpdi2.c b/lib/ucmpdi2.c
> index 25ca2d4c1e19..597998169a96 100644
> --- a/lib/ucmpdi2.c
> +++ b/lib/ucmpdi2.c
> @@ -17,7 +17,7 @@
>  #include <linux/module.h>
>  #include <linux/libgcc.h>
>
> -word_type __ucmpdi2(unsigned long long a, unsigned long long b)
> +word_type notrace __ucmpdi2(unsigned long long a, unsigned long long b)
>  {
>  	const DWunion au = {.ll = a};
>  	const DWunion bu = {.ll = b};

Ah, thanks, I think I must have forgotten about this.  I assume these three are 
going through your tree?