linux-kernel - Re: [PATCH] scsi: Introduce sdev_printk_ratelimited to throttle frequent printk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ab95f87c23832aed080d0c1b6f329471a26d549b.camel@wdc.com>
Date:   Thu, 29 Mar 2018 23:56:05 +0000
From:   Bart Van Assche <Bart.VanAssche@....com>
To:     "jejb@...ux.vnet.ibm.com" <jejb@...ux.vnet.ibm.com>,
        "wen.yang99@....com.cn" <wen.yang99@....com.cn>,
        "martin.petersen@...cle.com" <martin.petersen@...cle.com>
CC:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "jiang.biao2@....com.cn" <jiang.biao2@....com.cn>,
        "zhong.weidong@....com.cn" <zhong.weidong@....com.cn>,
        "sergey.senozhatsky.work@...il.com" 
        <sergey.senozhatsky.work@...il.com>,
        "pmladek@...e.com" <pmladek@...e.com>,
        "linux-scsi@...r.kernel.org" <linux-scsi@...r.kernel.org>,
        "tan.hu@....com.cn" <tan.hu@....com.cn>,
        "tj@...nel.org" <tj@...nel.org>
Subject: Re: [PATCH] scsi: Introduce sdev_printk_ratelimited to throttle
 frequent printk

On Wed, 2018-03-28 at 16:43 +0800, Wen Yang wrote:
> There would be so many same lines printed by frequent prink if one 
> disk went wrong, like,
> [  546.185242] sd 0:1:0:0: rejecting I/O to offline device
> [  546.185258] sd 0:1:0:0: rejecting I/O to offline device
> [  546.185280] sd 0:1:0:0: rejecting I/O to offline device
> [  546.185307] sd 0:1:0:0: rejecting I/O to offline device
> [  546.185334] sd 0:1:0:0: rejecting I/O to offline device
> [  546.185364] sd 0:1:0:0: rejecting I/O to offline device
> [  546.185390] sd 0:1:0:0: rejecting I/O to offline device
> [  546.185410] sd 0:1:0:0: rejecting I/O to offline device
> For slow serial console, the frequent prink may block the printk, and 
> if spin_lock was acquired before the printk like in scsi_request_fn,
> that could trigger the watchdog.
> 
> Relative disscussion can be found here,
  ^^^^^^^^
  Related?

Anyway:

Reviewed-by: Bart Van Assche <bart.vanassche@....com>