linux-kernel - Re: [PATCH v3 0/5] Support perf -vv

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20180329083358.GA28857@krava>
Date:   Thu, 29 Mar 2018 10:33:58 +0200
From:   Jiri Olsa <jolsa@...hat.com>
To:     "Jin, Yao" <yao.jin@...ux.intel.com>
Cc:     Ingo Molnar <mingo@...nel.org>, acme@...nel.org, jolsa@...nel.org,
        peterz@...radead.org, mingo@...hat.com,
        alexander.shishkin@...ux.intel.com, Linux-kernel@...r.kernel.org,
        ak@...ux.intel.com, kan.liang@...el.com, yao.jin@...el.com
Subject: Re: [PATCH v3 0/5] Support perf -vv

On Thu, Mar 29, 2018 at 03:49:18PM +0800, Jin, Yao wrote:

SNIP

> > That would make it easier to grep around in the source looking for where code
> > related a particular features is located.
> > 
> 
> Good idea, thanks! I will support it in v4.
> 
> > BTW. #2: to the compulsive perfectionist in me "HAVE_DWARF_GETLOCATIONS" is now
> > sticking out like a sore thumb: it's the only library flag left that doesn't have
> > the _SUPPORT suffix. Rename it to HAVE_DWARF_GETLOCATIONS_SUPPORT perhaps?
> > 
> > Thanks,
> >
> > 	Ingo
> >
> 
> OK, I will rename it to HAVE_DWARF_GETLOCATIONS_SUPPORT in v4.

thanks for doing this, I'll ack the new version then

jirka