linux-kernel - Re: [PATCH v4 02/16] riscv: Use generic free_initrd

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87y3ibrv87.fsf@xps13.shealevy.com>
Date:   Thu, 29 Mar 2018 07:12:40 -0400
From:   Shea Levy <shea@...alevy.com>
To:     Daniel Thompson <daniel.thompson@...aro.org>,
        linux-riscv@...ts.infradead.org, linux-kernel@...r.kernel.org
Cc:     Palmer Dabbelt <palmer@...ive.com>, Albert Ou <albert@...ive.com>
Subject: Re: [PATCH v4 02/16] riscv: Use generic free_initrd_mem.

Daniel Thompson <daniel.thompson@...aro.org> writes:

> On 28/03/18 21:36, Shea Levy wrote:
>> Signed-off-by: Shea Levy <shea@...alevy.com>
>> ---
>>   arch/riscv/mm/init.c | 6 ------
>>   1 file changed, 6 deletions(-)
>> 
>> diff --git a/arch/riscv/mm/init.c b/arch/riscv/mm/init.c
>> index c77df8142be2..36f83fe8a726 100644
>> --- a/arch/riscv/mm/init.c
>> +++ b/arch/riscv/mm/init.c
>> @@ -62,9 +62,3 @@ void free_initmem(void)
>>   {
>>   	free_initmem_default(0);
>>   }
>> -
>> -#ifdef CONFIG_BLK_DEV_INITRD
>> -void free_initrd_mem(unsigned long start, unsigned long end)
>> -{
>> -}
>> -#endif /* CONFIG_BLK_DEV_INITRD */
>
> This looks like a change of behavior since the weakly defined code does 
> not implement a nop.
>
> I'm not saying the change is wrong, but if this is a deliberate bug fix 
> then we need more than an empty commit message to explain what is 
> happening here.
>

Right, sorry, will re-send with a proper commit message here.

>
>
> Daniel.

Download attachment "signature.asc" of type "application/pgp-signature" (833 bytes)