linux-kernel - Re: [RESEND] rtc: snvs: Fix usage of snvs_rtc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 29 Mar 2018 02:53:44 +0100
From:   Bryan O'Donoghue <pure.logic@...us-software.ie>
To:     Trent Piepho <tpiepho@...inj.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "alexandre.belloni@...e-electrons.com" 
        <alexandre.belloni@...e-electrons.com>
Cc:     "shawn.guo@...aro.org" <shawn.guo@...aro.org>,
        "stefan@...er.ch" <stefan@...er.ch>,
        "bianpan2016@....com" <bianpan2016@....com>,
        "a.zummo@...ertech.it" <a.zummo@...ertech.it>,
        "stable@...r.kernel.org" <stable@...r.kernel.org>,
        "guy.shapiro@...i-wize.com" <guy.shapiro@...i-wize.com>,
        "Frank.Li@...escale.com" <Frank.Li@...escale.com>,
        "linux-rtc@...r.kernel.org" <linux-rtc@...r.kernel.org>
Subject: Re: [RESEND] rtc: snvs: Fix usage of snvs_rtc_enable

On 29/03/18 01:12, Trent Piepho wrote:

> I sent a patch a couple weeks ago that addressed a similar issue, see
> https://patchwork.ozlabs.org/patch/887090/
> 
> Does this also fix the problem you see?

It breaks the endless loop that happens later on in the RTC read path.

This patch though is about fixing the bug with not handling the enable 
of the snvs_rtc_enable() correctly, which is why it should be applied.

The right flow is to handle the error on snvs_rtc_enable() as soon as it 
happens as opposed wait for read() to -ETIMEDOUT.

> I think what you've done will prevent the driver from loading if the
> clock is not working, but if the clock does not tick properly after
> loading, there are still points (snvs_rtc_read_time for one) that will
> lock up in the kernel.

I'll dig out your patch and give it a review.

---
bod