linux-kernel - Re: [PATCH 1/3] virt: vbox: Add vbg_req

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180329115630.GB6734@kroah.com>
Date:   Thu, 29 Mar 2018 13:56:30 +0200
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Hans de Goede <hdegoede@...hat.com>
Cc:     Arnd Bergmann <arnd@...db.de>,
        Michael Thayer <michael.thayer@...cle.com>,
        linux-kernel@...r.kernel.org, stable@...r.kernel.org
Subject: Re: [PATCH 1/3] virt: vbox: Add vbg_req_free() helper function

On Thu, Mar 29, 2018 at 01:21:14PM +0200, Hans de Goede wrote:
> +void vbg_req_free(void *req, size_t len)
> +{
> +	if (!req)
> +		return;
> +
> +	kfree(req);
> +}

Wait, no, this isn't ok.  Don't create wrapper functions that you never
use except as a wrapper :(

I can see someone sending me almost the indental revert patch right
after this one gets applied...

thanks,

greg k-h