linux-kernel - Re: [PATCH V4 3/3] mmc: sdhci: Add MSI interrupt support for O2 SD host

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ac6505aa-603f-f10e-70fa-7c51af77f7fa@intel.com>
Date:   Thu, 29 Mar 2018 15:44:50 +0300
From:   Adrian Hunter <adrian.hunter@...el.com>
To:     "ernest.zhang" <ernest.zhang@...hubtech.com>,
        Ulf Hansson <ulf.hansson@...aro.org>,
        linux-mmc@...r.kernel.org, linux-kernel@...r.kernel.org
Cc:     xiaoguang.yu@...hubtech.com, shirley.her@...hubtech.com,
        yuxiang.wan@...hubtech.com
Subject: Re: [PATCH V4 3/3] mmc: sdhci: Add MSI interrupt support for O2 SD
 host

On 09/03/18 16:04, ernest.zhang wrote:
> Add MSI interrupt support if the SD host device can support MSI interrupt.
> 
> Changes: Enable MSI interrupt if the MSI capability bit is set in 
> capability register.
> 
> Signed-off-by: ernest.zhang <ernest.zhang@...hubtech.com>
> ---
>  drivers/mmc/host/sdhci-pci-o2micro.c | 17 +++++++++++++++++
>  1 file changed, 17 insertions(+)
> 
> diff --git a/drivers/mmc/host/sdhci-pci-o2micro.c b/drivers/mmc/host/sdhci-pci-o2micro.c
> index a918984..7d04f4b 100644
> --- a/drivers/mmc/host/sdhci-pci-o2micro.c
> +++ b/drivers/mmc/host/sdhci-pci-o2micro.c
> @@ -391,6 +391,23 @@ int sdhci_pci_o2_probe_slot(struct sdhci_pci_slot *slot)
>  		if (reg & 0x1)
>  			host->quirks |= SDHCI_QUIRK_MULTIBLOCK_READ_ACMD12;
>  
> +#if defined(CONFIG_PCI_MSI)

Do you really need to check CONFIG_PCI_MSI ?

> +		if (pci_find_capability(chip->pdev, PCI_CAP_ID_MSI)) {
> +			ret = pci_enable_msi(chip->pdev);
> +			if (!ret) {
> +				host->irq = chip->pdev->irq;
> +				pr_info("%s: use MSI irq, irq=%d\n",
> +					mmc_hostname(host->mmc), host->irq);
> +			} else {
> +				pr_err("%s: enable PCI MSI failed, err=%d\n",
> +					mmc_hostname(host->mmc), ret);
> +			}
> +		} else {
> +			pr_info("%s: unsupport msi, use INTx irq\n",
> +				mmc_hostname(host->mmc));
> +		}
> +#endif
> +
>  		if (chip->pdev->device == PCI_DEVICE_ID_O2_SEABIRD0) {
>  			ret = pci_read_config_dword(chip->pdev,
>  						    O2_SD_MISC_SETTING, &reg);
>