linux-kernel - Re: [PATCH 1/1] xen-netback: process malformed sk_buff correctly to avoid BUG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20180329.120903.1175452061863560219.davem@davemloft.net>
Date:   Thu, 29 Mar 2018 12:09:03 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     dongli.zhang@...cle.com
Cc:     xen-devel@...ts.xenproject.org, linux-kernel@...r.kernel.org,
        netdev@...r.kernel.org, wei.liu2@...rix.com,
        paul.durrant@...rix.com
Subject: Re: [PATCH 1/1] xen-netback: process malformed sk_buff correctly
 to avoid BUG_ON()

From: Dongli Zhang <dongli.zhang@...cle.com>
Date: Wed, 28 Mar 2018 07:42:16 +0800

> The "BUG_ON(!frag_iter)" in function xenvif_rx_next_chunk() is triggered if
> the received sk_buff is malformed, that is, when the sk_buff has pattern
> (skb->data_len && !skb_shinfo(skb)->nr_frags). Below is a sample call
> stack:

We should fix the parts of the kernel which build illegal malformed
SKBs rather than adding checks to every driver in the tree.

I'm not applying this, sorry.