linux-kernel - Re: [PATCH v2 02/19] powerpc/powermac: Mark variable x as unused

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180329180922.Horde.Mtq3N9paq5gkMn9QcIUlGQ1@messagerie.si.c-s.fr>
Date:   Thu, 29 Mar 2018 18:09:22 +0200
From:   LEROY Christophe <christophe.leroy@....fr>
To:     Mathieu Malaterre <malat@...ian.org>
Cc:     linux-kernel@...r.kernel.org, linuxppc-dev@...ts.ozlabs.org,
        Paul Mackerras <paulus@...ba.org>,
        Benjamin Herrenschmidt <benh@...nel.crashing.org>,
        Michael Ellerman <mpe@...erman.id.au>
Subject: Re: [PATCH v2 02/19] powerpc/powermac: Mark variable x as unused

Mathieu Malaterre <malat@...ian.org> a écrit :

> Since the value of x is never intended to be read, remove it. Fix warning
> treated as error with W=1:
>
>   arch/powerpc/platforms/powermac/udbg_scc.c:76:9: error: variable  
> ‘x’ set but not used [-Werror=unused-but-set-variable]
>
> Suggested-by: Christophe Leroy <christophe.leroy@....fr>
> Signed-off-by: Mathieu Malaterre <malat@...ian.org>

Reviewed-by: Christophe Leroy <christophe.leroy@....fr>

> ---
> v2: remove x completely
>
>  arch/powerpc/platforms/powermac/udbg_scc.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/powerpc/platforms/powermac/udbg_scc.c  
> b/arch/powerpc/platforms/powermac/udbg_scc.c
> index d83135a9830e..8901973ed683 100644
> --- a/arch/powerpc/platforms/powermac/udbg_scc.c
> +++ b/arch/powerpc/platforms/powermac/udbg_scc.c
> @@ -73,7 +73,7 @@ void udbg_scc_init(int force_scc)
>  	struct device_node *stdout = NULL, *escc = NULL, *macio = NULL;
>  	struct device_node *ch, *ch_def = NULL, *ch_a = NULL;
>  	const char *path;
> -	int i, x;
> +	int i;
>
>  	escc = of_find_node_by_name(NULL, "escc");
>  	if (escc == NULL)
> @@ -120,7 +120,7 @@ void udbg_scc_init(int force_scc)
>  	mb();
>
>  	for (i = 20000; i != 0; --i)
> -		x = in_8(sccc);
> +		in_8(sccc);
>  	out_8(sccc, 0x09);		/* reset A or B side */
>  	out_8(sccc, 0xc0);
>
> --
> 2.11.0