lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <20180330082221.cea5hz7kq3gyg7w5@quack2.suse.cz> Date: Fri, 30 Mar 2018 10:22:21 +0200 From: Jan Kara <jack@...e.cz> To: Dan Williams <dan.j.williams@...el.com> Cc: Jan Kara <jack@...e.cz>, linux-nvdimm <linux-nvdimm@...ts.01.org>, Jeff Moyer <jmoyer@...hat.com>, Matthew Wilcox <mawilcox@...rosoft.com>, Ross Zwisler <ross.zwisler@...ux.intel.com>, Christoph Hellwig <hch@....de>, david <david@...morbit.com>, linux-fsdevel <linux-fsdevel@...r.kernel.org>, linux-xfs <linux-xfs@...r.kernel.org>, Linux Kernel Mailing List <linux-kernel@...r.kernel.org> Subject: Re: [PATCH v7 07/14] fs, dax: use page->mapping to warn if truncate collides with a busy page On Thu 29-03-18 16:02:45, Dan Williams wrote: > On Thu, Mar 29, 2018 at 9:02 AM, Jan Kara <jack@...e.cz> wrote: > > On Wed 21-03-18 15:57:48, Dan Williams wrote: > [..] > > I find it quite tricky that in case we pass zero page / empty entry into > > dax_[dis]associate_entry(), it will not do anything because > > dax_entry_size() will return 0. Can we add an explicit check into > > dax_[dis]associate_entry() or at least a comment there? > > How about the following, i.e. rename the loop helper to > for_each_dax_pfn() to make it clearer that we're only operating on > mapped pfns, and also add a comment to indicate the same: > > /* > * Iterate through all mapped pfns represented by an entry, i.e. skip > * 'empty' and 'zero' entries. > */ > #define for_each_dax_pfn(entry, pfn) \ > for (pfn = dax_radix_pfn(entry); \ > pfn < dax_radix_end_pfn(entry); pfn++) Maybe call it for_each_mapped_pfn()? Other than that it looks fine to me. Honza -- Jan Kara <jack@...e.com> SUSE Labs, CR
Powered by blists - more mailing lists