| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <CACjP9X94DSJZOAgbjw+suRQJZ-X2dN3WrJaKNDLUBPjP8PFv1w@mail.gmail.com>
Date: Fri, 30 Mar 2018 11:24:26 +0200
From: Daniel Vacek <neelx@...hat.com>
To: Jia He <hejianet@...il.com>
Cc: Russell King <linux@...linux.org.uk>,
Andrew Morton <akpm@...ux-foundation.org>,
Michal Hocko <mhocko@...e.com>,
Catalin Marinas <catalin.marinas@....com>,
Mel Gorman <mgorman@...e.de>,
Will Deacon <will.deacon@....com>,
Mark Rutland <mark.rutland@....com>,
"H. Peter Anvin" <hpa@...or.com>,
Pavel Tatashin <pasha.tatashin@...cle.com>,
Daniel Jordan <daniel.m.jordan@...cle.com>,
AKASHI Takahiro <takahiro.akashi@...aro.org>,
Gioh Kim <gi-oh.kim@...fitbricks.com>,
Steven Sistare <steven.sistare@...cle.com>,
Eugeniu Rosca <erosca@...adit-jv.com>,
Vlastimil Babka <vbabka@...e.cz>,
open list <linux-kernel@...r.kernel.org>, linux-mm@...ck.org,
James Morse <james.morse@....com>,
Ard Biesheuvel <ard.biesheuvel@...aro.org>,
Steve Capper <steve.capper@....com>,
Thomas Gleixner <tglx@...utronix.de>,
Ingo Molnar <mingo@...hat.com>, x86@...nel.org,
Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
Kate Stewart <kstewart@...uxfoundation.org>,
Philippe Ombredanne <pombredanne@...b.com>,
Johannes Weiner <hannes@...xchg.org>,
Kemi Wang <kemi.wang@...el.com>,
Petr Tesarik <ptesarik@...e.com>,
YASUAKI ISHIMATSU <yasu.isimatu@...il.com>,
Andrey Ryabinin <aryabinin@...tuozzo.com>,
Nikolay Borisov <nborisov@...e.com>, richard.weiyang@...il.com,
Jia He <jia.he@...-semitech.com>
Subject: Re: [PATCH v4 4/5] arm64: introduce pfn_valid_region()
On Fri, Mar 30, 2018 at 10:15 AM, Jia He <hejianet@...il.com> wrote:
> This is the preparation for further optimizing in early_pfn_valid
> on arm and arm64.
>
> Signed-off-by: Jia He <jia.he@...-semitech.com>
> ---
> arch/arm/include/asm/page.h | 3 ++-
> arch/arm/mm/init.c | 23 +++++++++++++++++++++++
> arch/arm64/include/asm/page.h | 3 ++-
> arch/arm64/mm/init.c | 23 +++++++++++++++++++++++
> 4 files changed, 50 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/include/asm/page.h b/arch/arm/include/asm/page.h
> index 7a0404f..559b414 100644
> --- a/arch/arm/include/asm/page.h
> +++ b/arch/arm/include/asm/page.h
> @@ -158,7 +158,8 @@ typedef struct page *pgtable_t;
>
> #ifdef CONFIG_HAVE_ARCH_PFN_VALID
> extern int early_region_idx;
> -extern int pfn_valid(unsigned long);
> +extern int pfn_valid(unsigned long pfn);
> +extern int pfn_valid_region(unsigned long pfn, int *last_idx);
> #endif
>
> #include <asm/memory.h>
> diff --git a/arch/arm/mm/init.c b/arch/arm/mm/init.c
> index 7779804..11f9b82 100644
> --- a/arch/arm/mm/init.c
> +++ b/arch/arm/mm/init.c
> @@ -201,6 +201,29 @@ int pfn_valid(unsigned long pfn)
> }
> EXPORT_SYMBOL(pfn_valid);
>
> +int pfn_valid_region(unsigned long pfn, int *last_idx)
> +{
> + unsigned long start_pfn, end_pfn;
> + struct memblock_type *type = &memblock.memory;
> + struct memblock_region *regions = type->regions;
> +
> + if (*last_idx != -1) {
> + start_pfn = PFN_DOWN(regions[*last_idx].base);
> + end_pfn = PFN_DOWN(regions[*last_idx].base +
> + regions[*last_idx].size);
> +
> + if (pfn >= start_pfn && pfn < end_pfn)
> + return !memblock_is_nomap(®ions[*last_idx]);
> + }
> +
> + *last_idx = memblock_search_pfn_regions(pfn);
> + if (*last_idx == -1)
> + return false;
> +
> + return !memblock_is_nomap(®ions[*last_idx]);
> +}
> +EXPORT_SYMBOL(pfn_valid_region);
> +
> /* HAVE_MEMBLOCK is always enabled on arm */
> unsigned long __init_memblock memblock_next_valid_pfn(unsigned long pfn,
> int *last_idx)
Since you have both functions in the same file, can you make the
early_region_idx global static here and get rid of the arguments,
perhaps?
> diff --git a/arch/arm64/include/asm/page.h b/arch/arm64/include/asm/page.h
> index 84b503a..27892d5 100644
> --- a/arch/arm64/include/asm/page.h
> +++ b/arch/arm64/include/asm/page.h
> @@ -39,7 +39,8 @@ typedef struct page *pgtable_t;
>
> #ifdef CONFIG_HAVE_ARCH_PFN_VALID
> extern int early_region_idx;
> -extern int pfn_valid(unsigned long);
> +extern int pfn_valid(unsigned long pfn);
> +extern int pfn_valid_region(unsigned long pfn, int *last_idx);
> #endif
>
> #include <asm/memory.h>
> diff --git a/arch/arm64/mm/init.c b/arch/arm64/mm/init.c
> index cd9b473..6dedd77 100644
> --- a/arch/arm64/mm/init.c
> +++ b/arch/arm64/mm/init.c
> @@ -293,6 +293,29 @@ int pfn_valid(unsigned long pfn)
> }
> EXPORT_SYMBOL(pfn_valid);
>
> +int pfn_valid_region(unsigned long pfn, int *last_idx)
> +{
> + unsigned long start_pfn, end_pfn;
> + struct memblock_type *type = &memblock.memory;
> + struct memblock_region *regions = type->regions;
> +
> + if (*last_idx != -1) {
> + start_pfn = PFN_DOWN(regions[*last_idx].base);
> + end_pfn = PFN_DOWN(regions[*last_idx].base +
> + regions[*last_idx].size);
> +
> + if (pfn >= start_pfn && pfn < end_pfn)
> + return !memblock_is_nomap(®ions[*last_idx]);
> + }
> +
> + *last_idx = memblock_search_pfn_regions(pfn);
> + if (*last_idx == -1)
> + return false;
> +
> + return !memblock_is_nomap(®ions[*last_idx]);
> +}
> +EXPORT_SYMBOL(pfn_valid_region);
> +
> /* HAVE_MEMBLOCK is always enabled on arm64 */
> unsigned long __init_memblock memblock_next_valid_pfn(unsigned long pfn,
> int *last_idx)
Ditto.
--nX
> --
> 2.7.4
>
Powered by blists - more mailing lists