linux-kernel - Re: [PATCH v3 2/2] drivers: soc: Add LLCC driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9d6dad94-3e17-2ca6-2921-3f461e8315ca@codeaurora.org>
Date:   Thu, 29 Mar 2018 17:31:47 -0700
From:   Trilok Soni <tsoni@...eaurora.org>
To:     Stanimir Varbanov <stanimir.varbanov@...aro.org>,
        Rishabh Bhatnagar <rishabhb@...eaurora.org>,
        linux-arm-kernel@...ts.infradead.org, linux-arm-msm@...r.kernel.org
Cc:     linux-arm@...ts.infradead.org, linux-kernel@...r.kernel.org,
        kyan@...eaurora.org, ckadabi@...eaurora.org
Subject: Re: [PATCH v3 2/2] drivers: soc: Add LLCC driver

Hi Stanimir,

+/* Get the slice entry by index */
>> +static struct llcc_slice_desc *llcc_slice_get_entry(struct device *dev, int n)
> drop this *slice* word from function names

Please note that we are activating/de-activating  a "slice" of the LLCC 
and not a whole LLCC. "slice" makes perfect sense here since the 
granularity is at the "slice" level and not the complete LLCC.

--Trilok Soni