linux-kernel - Re: [v3] hwmon, via-cputem: support new centaur CPUs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20180330145540.GA13899@roeck-us.net>
Date:   Fri, 30 Mar 2018 07:55:40 -0700
From:   Guenter Roeck <linux@...ck-us.net>
To:     davidwang <davidwang@...oxin.com>
Cc:     jdelvare@...e.com, tglx@...utronix.de, mingo@...hat.com,
        rafel.j.wysocki@...el.com, linux-hwmon@...r.kernel.org,
        linux-kernel@...r.kernel.org, brucechang@...-alliance.com,
        cooperyan@...oxin.com, qiyuanwang@...oxin.com,
        benjaminpan@...tech.com, lukelin@...cpu.com, timguo@...oxin.com
Subject: Re: [v3] hwmon, via-cputem: support new centaur CPUs

On Fri, Mar 30, 2018 at 09:04:48AM +0800, davidwang wrote:
> New centaur CPUs(Familiy == 7) also support this cpu temperature sensor.
> 
> Change from v2 to v3:
> *replace "goto" with "if...else.." according to suggestion from Guenter
>  
> Change from v1 to v2:
> *fixed the wrong if condition in patch v1.
> 	
> Signed-off-by: David Wang <davidwang@...oxin.com>

Applied to hwmon-next.

Thanks,
Guenter

> ---
>  drivers/hwmon/via-cputemp.c | 31 ++++++++++++++++++-------------
>  1 file changed, 18 insertions(+), 13 deletions(-)
> 
> diff --git a/drivers/hwmon/via-cputemp.c b/drivers/hwmon/via-cputemp.c
> index 07a0cb0..0e81f28 100644
> --- a/drivers/hwmon/via-cputemp.c
> +++ b/drivers/hwmon/via-cputemp.c
> @@ -136,20 +136,24 @@ static int via_cputemp_probe(struct platform_device *pdev)
>  	data->id = pdev->id;
>  	data->name = "via_cputemp";
>  
> -	switch (c->x86_model) {
> -	case 0xA:
> -		/* C7 A */
> -	case 0xD:
> -		/* C7 D */
> -		data->msr_temp = 0x1169;
> -		data->msr_vid = 0x198;
> -		break;
> -	case 0xF:
> -		/* Nano */
> +	if (c->x86 == 7) {
>  		data->msr_temp = 0x1423;
> -		break;
> -	default:
> -		return -ENODEV;
> +	} else {
> +		switch (c->x86_model) {
> +		case 0xA:
> +			/* C7 A */
> +		case 0xD:
> +			/* C7 D */
> +			data->msr_temp = 0x1169;
> +			data->msr_vid = 0x198;
> +			break;
> +		case 0xF:
> +			/* Nano */
> +			data->msr_temp = 0x1423;
> +			break;
> +		default:
> +			return -ENODEV;
> +		}
>  	}
>  
>  	/* test if we can access the TEMPERATURE MSR */
> @@ -283,6 +287,7 @@ static int via_cputemp_down_prep(unsigned int cpu)
>  	{ X86_VENDOR_CENTAUR, 6, 0xa, }, /* C7 A */
>  	{ X86_VENDOR_CENTAUR, 6, 0xd, }, /* C7 D */
>  	{ X86_VENDOR_CENTAUR, 6, 0xf, }, /* Nano */
> +	{ X86_VENDOR_CENTAUR, 7, X86_MODEL_ANY, },
>  	{}
>  };
>  MODULE_DEVICE_TABLE(x86cpu, cputemp_ids);