linux-kernel - Re: [PATCH] net: mvneta: remove duplicate *

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20180330.122811.462608073364510854.davem@davemloft.net>
Date:   Fri, 30 Mar 2018 12:28:11 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     Jisheng.Zhang@...aptics.com
Cc:     thomas.petazzoni@...tlin.com, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH] net: mvneta: remove duplicate *_coal assignment

From: Jisheng Zhang <Jisheng.Zhang@...aptics.com>
Date: Thu, 29 Mar 2018 17:29:40 +0800

> The style of the rx/tx queue's *_coal member assignment is:
> 
> static void foo_coal_set(...)
> {
> 	set the coal in hw;
> 	update queue's foo_coal member; [1]
> }
> 
> In other place, we call foo_coal_set(pp, queue->foo_coal), so the above [1]
> is duplicated and could be removed.
> 
> Signed-off-by: Jisheng Zhang <Jisheng.Zhang@...aptics.com>

Applied.

We could make this convention even more explicit by not passing
the coalescing parameter into these helpers, but instead using
the value in rxq->foo and txq->foo.