linux-kernel - Re: [PATCH] Input: add bu21029 touch driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20180330181938.GD143703@dtor-ws>
Date:   Fri, 30 Mar 2018 11:19:38 -0700
From:   Dmitry Torokhov <dmitry.torokhov@...il.com>
To:     "Jonas Mark (BT-FIR/ENG1)" <Mark.Jonas@...bosch.com>
Cc:     Rob Herring <robh+dt@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        "linux-input@...r.kernel.org" <linux-input@...r.kernel.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "hs@...x.de" <hs@...x.de>,
        "ZHU Yi (BT-FIR/ENG1-Zhu)" <Yi.Zhu5@...bosch.com>
Subject: Re: [PATCH] Input: add bu21029 touch driver

On Tue, Mar 27, 2018 at 06:57:42AM +0000, Jonas Mark (BT-FIR/ENG1) wrote:
> > > +	/* calculate Rz (pressure resistance value) by equation:
> > > +	 * Rz = Rx * (x/Q) * ((z2/z1) - 1), where
> > > +	 * Rx is x-plate resistance,
> > > +	 * Q  is the touch screen resolution (8bit = 256, 12bit = 4096)
> > > +	 * x, z1, z2 are the measured positions.
> > > +	 */
> > > +	rz  = z2 - z1;
> > > +	rz *= x;
> > > +	rz *= bu21029->x_plate_ohms;
> > > +	rz /= z1;
> > > +	rz  = DIV_ROUND_CLOSEST(rz, SCALE_12BIT);
> > > +	if (rz <= bu21029->max_pressure) {
> > > +		input_report_abs(bu21029->in_dev, ABS_X, x);
> > > +		input_report_abs(bu21029->in_dev, ABS_Y, y);
> > > +		input_report_abs(bu21029->in_dev, ABS_PRESSURE, rz);
> > 
> > What is the values of pressure reported when finger is touching the
> > surface? IOW is 'rz' pressure or resistance?
> 
> Rz is pressure measured in Ohms. That is, it is a resistance which
> correlates with finger pressure.
> 
> I fear that I do not understand your question. Does ABS_PRESSURE have
> to be reported in a specific unit, e.g. milli Newton? We thought that
> it is a device specific scale and that it will be converted into a
> calibrated value (just like the coordinates) in user space.

What I was trying to say is that it is expected that ABS_PRESSURE values
grow the harder you press on the screen, and reduce back to 0 when
finger is about to be removed from the surface. Here, it seems, we have
the opposite case, where resistance decreases the harder you press and
increases up to some maximum value when you remove the finger.

IOW, I think you want to report:

		input_report_abs(bu21029->in_dev, ABS_PRESSURE,
				 bu21029->max_pressure - rz);

Thanks.

-- 
Dmitry