linux-kernel - Re: [PATCH 01/17] staging: lustre: remove invariant in cl_io_read

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LFD.2.21.1803301956160.9681@casper.infradead.org>
Date:   Fri, 30 Mar 2018 19:56:45 +0100 (BST)
From:   James Simmons <jsimmons@...radead.org>
To:     NeilBrown <neilb@...e.com>
cc:     Oleg Drokin <oleg.drokin@...el.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Andreas Dilger <andreas.dilger@...el.com>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Lustre Development List <lustre-devel@...ts.lustre.org>
Subject: Re: [PATCH 01/17] staging: lustre: remove invariant in
 cl_io_read_ahead()


> This invariant can fail as ci_type is somtimes CIS_INIT.
> 
> According to Jinshan Xiong, or of the most recent significant
> change to this code, "We should get rid of it."
> 
> So do that.

Reviewed-by: James Simmons <jsimmons@...radead.org>
 
> Fixes: 1e1db2a97be5 ("staging: lustre: clio: Revise read ahead implementation")
> Cc: Jinshan Xiong <jinshan.xiong@...el.com>
> Signed-off-by: NeilBrown <neilb@...e.com>
> ---
>  drivers/staging/lustre/lustre/obdclass/cl_io.c |    1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/staging/lustre/lustre/obdclass/cl_io.c b/drivers/staging/lustre/lustre/obdclass/cl_io.c
> index ab84e011b560..fcdae6029258 100644
> --- a/drivers/staging/lustre/lustre/obdclass/cl_io.c
> +++ b/drivers/staging/lustre/lustre/obdclass/cl_io.c
> @@ -599,7 +599,6 @@ int cl_io_read_ahead(const struct lu_env *env, struct cl_io *io,
>  	int		       result = 0;
>  
>  	LINVRNT(io->ci_type == CIT_READ || io->ci_type == CIT_FAULT);
> -	LINVRNT(io->ci_state == CIS_IO_GOING || io->ci_state == CIS_LOCKED);
>  	LINVRNT(cl_io_invariant(io));
>  
>  	cl_io_for_each(scan, io) {
> 
> 
>