linux-kernel - Re: [PATCH] blktrace: fix comment in blktrace

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <c13a34d5-9e4f-6c57-2b56-63dcb6c9ae27@kernel.dk>
Date:   Fri, 30 Mar 2018 14:17:07 -0600
From:   Jens Axboe <axboe@...nel.dk>
To:     Souvik Banerjee <souvik1997@...il.com>
Cc:     Eric Biggers <ebiggers@...gle.com>,
        "Steven Rostedt (VMware)" <rostedt@...dmis.org>,
        Philippe Ombredanne <pombredanne@...b.com>,
        Kate Stewart <kstewart@...uxfoundation.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Shaohua Li <shli@...com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] blktrace: fix comment in blktrace_api.h

On 3/30/18 1:32 PM, Souvik Banerjee wrote:
> The `__u64 time` field of the blk_io_trace struct refers to
> the time in nanoseconds, not in microseconds. It is set in
> __blk_add_trace, which does the following:
> 
>     t->time = ktime_to_ns(ktime_get());
> 
> ktime_to_ns returns ktime_t in nanoseconds, not microseconds.

Thanks, applied. Back way back when it used to be in microseconds, iirc,
I'm guessing the comment dates to back then.

-- 
Jens Axboe