linux-kernel - Re: [PATCH 1/9] staging: ks7010: Replace manual array copy with ether_addr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1522389962.2210.38.camel@perches.com>
Date:   Thu, 29 Mar 2018 23:06:02 -0700
From:   Joe Perches <joe@...ches.com>
To:     Quytelda Kahja <quytelda@...alin.org>
Cc:     Greg KH <gregkh@...uxfoundation.org>, wsa@...-dreams.de,
        driverdev-devel@...uxdriverproject.org, devel@...verdev.osuosl.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/9] staging: ks7010: Replace manual array copy with
 ether_addr_copy().

On Thu, 2018-03-29 at 23:03 -0700, Quytelda Kahja wrote:
> If we just want to have the address field full of zeros during the
> driver probe, is there a reason we should zero it explicitly here?
> When the 'struct net_device' is first allocated using
> alloc_etherdev(), the dev_addr field is explicitly set to zeros (in
> the subfunction dev_addr_init() in net/core/dev_addr_lists.c), so it
> should be zeroed already at this point in the code.

You didn't describe the removal in your commit message
so it looked unintentional.

You should describe _why_ it's OK to remove it in that
commit message.