linux-kernel - Re: [PATCH v2 69/75] staging: ks7010: Remove extra blank line between functions.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sat, 31 Mar 2018 11:43:13 +0300
From:   Dan Carpenter <dan.carpenter@...cle.com>
To:     Quytelda Kahja <quytelda@...alin.org>
Cc:     gregkh@...uxfoundation.org, wsa@...-dreams.de,
        devel@...verdev.osuosl.org, driverdev-devel@...uxdriverproject.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 69/75] staging: ks7010: Remove extra blank line
 between functions.

On Fri, Mar 30, 2018 at 11:08:49PM -0700, Quytelda Kahja wrote:
> Remove an extra blank line indicated by checkpatch.
> 
> Signed-off-by: Quytelda Kahja <quytelda@...alin.org>
> ---
>  drivers/staging/ks7010/ks7010_sdio.c | 3 ++-
>  drivers/staging/ks7010/ks_hostif.c   | 1 -
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/ks7010/ks7010_sdio.c b/drivers/staging/ks7010/ks7010_sdio.c
> index d083bf8d238e..930d1f7d7dbf 100644
> --- a/drivers/staging/ks7010/ks7010_sdio.c
> +++ b/drivers/staging/ks7010/ks7010_sdio.c
> @@ -305,7 +305,8 @@ static void tx_device_task(struct ks_wlan_private *priv)
>  	if (priv->dev_state >= DEVICE_STATE_BOOT) {
>  		ret = write_to_device(priv, sp->sendp, sp->size);
>  		if (ret) {
> -			netdev_err(priv->net_dev, "write_to_device error !!(%d)\n", ret);
> +			netdev_err(priv->net_dev,
> +				   "write_to_device() error (%d)!\n", ret);

Doesn't match the patch description...

>  			queue_delayed_work(priv->wq, &priv->rw_dwork, 1);
>  			return;
>  		}

regards,
dan carpenter