linux-kernel - Re: [PATCH 06/12] wireless: Convert simple uses of a static const Ethernet broadcast address

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sat, 31 Mar 2018 07:33:28 -0700
From:   Joe Perches <joe@...ches.com>
To:     Pkshih <pkshih@...ltek.com>, "huxm@...vell.com" <huxm@...vell.com>,
        "gbhat@...vell.com" <gbhat@...vell.com>,
        "jussi.kivilinna@....fi" <jussi.kivilinna@....fi>,
        "nishants@...vell.com" <nishants@...vell.com>,
        "kvalo@...eaurora.org" <kvalo@...eaurora.org>,
        "amitkarwar@...il.com" <amitkarwar@...il.com>,
        "chunkeey@...glemail.com" <chunkeey@...glemail.com>
Cc:     "linux-wireless@...r.kernel.org" <linux-wireless@...r.kernel.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "b43-dev@...ts.infradead.org" <b43-dev@...ts.infradead.org>
Subject: Re: [PATCH 06/12] wireless: Convert simple uses of a static const
 Ethernet broadcast address

On Sat, 2018-03-31 at 14:01 +0000, Pkshih wrote:
> On Sat, 2018-03-31 at 00:05 -0700, Joe Perches wrote:
> > Use the new ether_broadcast_addr global instead to save some object code.
[]
> > diff --git a/drivers/net/wireless/realtek/rtlwifi/core.c
[]
> > @@ -1649,7 +1648,7 @@ static int rtl_op_set_key(struct ieee80211_hw *hw, enum set_key_cmd cmd,
> >  			memcpy(rtlpriv->sec.key_buf[key_idx],
> >  			       key->key, key->keylen);
> >  			rtlpriv->sec.key_len[key_idx] = key->keylen;
> > -			memcpy(mac_addr, bcast_addr, ETH_ALEN);
> > +			memcpy(mac_addr, ether_broadcast_addr, ETH_ALEN);
> 
> Use ether_addr_copy(mac_addr, ether_broadcast_addr) ?

This should use eth_broadcast_addr(mac_addr) instead.

There are similar conversion still possible in the tree.
One day.