linux-kernel - Re: [PATCH v5] PCI: hv: Make sure the bus domain is really unique

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <F31FD99A-2356-4659-BEC1-91CAE1920B90@microsoft.com>
Date:   Sat, 31 Mar 2018 00:49:09 +0000
From:   Sridhar Pitchai <Sridhar.Pitchai@...rosoft.com>
To:     Bjorn Helgaas <helgaas@...nel.org>
CC:     Lorenzo Pieralisi <lorenzo.pieralisi@....com>,
        Haiyang Zhang <haiyangz@...rosoft.com>,
        Stephen Hemminger <sthemmin@...rosoft.com>,
        Bjorn Helgaas <bhelgaas@...gle.com>,
        Jake Oshins <jakeo@...rosoft.com>,
        Dexuan Cui <decui@...rosoft.com>,
        KY Srinivasan <kys@...rosoft.com>,
        "Michael Kelley (EOSG)" <Michael.H.Kelley@...rosoft.com>,
        "devel@...uxdriverproject.org" <devel@...uxdriverproject.org>,
        "linux-pci@...r.kernel.org" <linux-pci@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v5] PCI: hv: Make sure the bus domain is really unique

	>On 3/30/18, 2:23 PM, "Bjorn Helgaas" <helgaas@...nel.org> wrote:
	>   >On Fri, Mar 30, 2018 at 07:35:04PM +0000, Sridhar Pitchai wrote:
	>   >commit 4a9b0933bdfc ("PCI: hv: Use device serial number as PCI
	>   >domain") need to be reverted. Also, we no longer need it as commit
	>   >4a1626dd233e ("netvsc: transparent VF management") remove the
	>   >need for it.
	>
	>Do you mean 0c195567a8f6 ("netvsc: transparent VF management")?
	>
	>I don't see a 4a1626dd233e commit in Linus' tree.
	>

That is right. sha should be 4a1626dd233e.

	>The connection between 0c195567a8f6 ("netvsc: transparent VF
	>management") and this Hyper-V domain ID issue is not clear to me at
	>all.  But obviously I'm not a networking or a Hyper-V person.
	>
	>A hint in the changelog about what that connection is would be nice.
	>
	>   >Revert commit 4a9b0933bdfc ("PCI: hv: Use device serial number as PCI
	>   >domain") so we can reliably support multiple devices being assigned to
	>   >a guest.
	>   >
	>   >This revert should only be backported to kernels that contain commit
	>   >4a1626dd233e ("netvsc: transparent VF management").
	>   >
	>   >Fixes: 4a9b0933bdfc ("PCI: hv: Use device serial number as PCI domain")
	>   >Signed-off-by: Sridhar Pitchai <sridhar.pitchai@...rosoft.com>
	>   >Cc: stable@...r.kernel.org
	>
	>This backporting guidance is very confusing.
	>
	>4a9b0933bdfc ("PCI: hv: Use device serial number as PCI domain")
	>appeared in v4.11.
	>
	>0c195567a8f6 ("netvsc: transparent VF management") appeared in v4.14.
	>
	>The changelog and the "Fixes" tag both suggest that 4a9b0933bdfc was
	>flat-out buggy and should be reverted unconditionally.  That would
	>mean this patch should be applied to v4.11 and later stable kernels.
	>
	>But the changelog also says "only revert 4a9b0933bdfc if you have
	>0c195567a8f6".  That would mean this patch should only be applied to
	>v4.14 and later stable kernels.
	>
	>Which is it?  You can answer in this thread if you want, but Lorenzo
	>will ultimately be looking for a v6 patch with a corrected changelog.

It is the Case 1. We just need to revert 4a9b0933bdfc. I will remove the
reference to 0c195567a8f6 altogether in the commit message.

	>
	>I think Lorenzo is out this week, but I suspect he'll look at it next
	>week.
	>
	>Bjorn

I will send out the update patch version 6.

Thanks,
Sridhar Pitchai