linux-kernel - Re: [PATCH v2] staging: mt7621-eth: Fix sparse warning in ethtool.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 02 Apr 2018 09:34:58 +1000
From:   NeilBrown <neil@...wn.name>
To:     Chris Coffey <cmc@...blebit.net>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Matthias Brugger <matthias.bgg@...il.com>
Cc:     devel@...verdev.osuosl.org, linux-arm-kernel@...ts.infradead.org,
        linux-mediatek@...ts.infradead.org, linux-kernel@...r.kernel.org,
        Chris Coffey <cmc@...blebit.net>
Subject: Re: [PATCH v2] staging: mt7621-eth: Fix sparse warning in ethtool.c

On Thu, Mar 29 2018, Chris Coffey wrote:

> This fixes the following sparse warning:
>
> drivers/staging/mt7621-eth/ethtool.c:213:6: warning: symbol
> 'mtk_set_ethtool_ops' was not declared. Should it be static?
>
> Signed-off-by: Chris Coffey <cmc@...blebit.net>

Reviewed-by: NeilBrown <neil@...wn.name>

Thanks,
NeilBrown


> ---
> Changes in v2:
>  - Per GregKH's feedback (thanks!), don't add unnecessary new .h file
>  dependencies. This patch version reverts those changes and fixes the
>  problem directly in ethtool.c (which is that it didn't include
>  ethtool.h anywhere -- mtk_set_ethtool_ops is not static).
>
>  drivers/staging/mt7621-eth/ethtool.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/staging/mt7621-eth/ethtool.c b/drivers/staging/mt7621-eth/ethtool.c
> index 38ba0c040a..5268c5ca09 100644
> --- a/drivers/staging/mt7621-eth/ethtool.c
> +++ b/drivers/staging/mt7621-eth/ethtool.c
> @@ -13,6 +13,7 @@
>   */
>  
>  #include "mtk_eth_soc.h"
> +#include "ethtool.h"
>  
>  static const char mtk_gdma_str[][ETH_GSTRING_LEN] = {
>  #define _FE(x...)	# x,
> -- 
> 2.11.0

Download attachment "signature.asc" of type "application/pgp-signature" (833 bytes)