| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <s5hwoxp3kyz.wl-tiwai@suse.de>
Date: Mon, 02 Apr 2018 13:29:24 +0200
From: Takashi Iwai <tiwai@...e.de>
To: "Jian-Hong Pan" <jian-hong@...lessm.com>
Cc: <alsa-devel@...a-project.org>, "Hui Wang" <hui.wang@...onical.com>,
<linux@...lessm.com>, "Jaroslav Kysela" <perex@...ex.cz>,
"Kailang Yang" <kailang@...ltek.com>,
<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] ALSA: hda/realtek: Enable audio line out on ASUS D640SA
On Mon, 02 Apr 2018 09:33:13 +0200,
Jian-Hong Pan wrote:
>
> This ASUS D640SA desktop whose mother board is D640MB has
> - two jacks which are a headphone and a mic on the front panel,
> - three jacks which are a mic, a line out and a line in on the rear panel
> - one internal speaker.
>
> If I plug a headphone to the front headphone jack, there will be sound
> through the headphone jack, and no sound through the internal speaker.
> If I unplug the headphone from the the headphone jack, there will be
> sound through the internal speaker. And always no sound through rear
> line out, when I plug a headphone or an externel speaker to the rear
> line out jack.
>
> Besides, I had checked and toggled the Auto-Mute Mode in alsamixer, but
> the rear line out still was not working. Then I checked the sound
> settings in GUI, and found there was no "Line Out" could be chosen, only
> the "Headphones" and "HDMI/DisplayPort".
> However, system does know that there is an "Intel PCH Line Out".
>
> [ 10.089082] snd_hda_codec_realtek hdaudioC0D0: autoconfig for
> ALC887-VD: line_outs=1 (0x14/0x0/0x0/0x0/0x0) type:line
> [ 10.089083] snd_hda_codec_realtek hdaudioC0D0: speaker_outs=1
> (0x1a/0x0/0x0/0x0/0x0)
> [ 10.089084] snd_hda_codec_realtek hdaudioC0D0: hp_outs=1
> (0x1b/0x0/0x0/0x0/0x0)
> [ 10.089085] snd_hda_codec_realtek hdaudioC0D0: mono: mono_out=0x0
> [ 10.089086] snd_hda_codec_realtek hdaudioC0D0: inputs:
> [ 10.089087] snd_hda_codec_realtek hdaudioC0D0: Rear Mic=0x18
> [ 10.089088] snd_hda_codec_realtek hdaudioC0D0: Front Mic=0x19
> [ 10.089089] snd_hda_codec_realtek hdaudioC0D0: Line=0x15
> [ 10.104387] input: HDA Intel PCH Rear Mic as
> /devices/pci0000:00/0000:00:1f.3/sound/card0/input9
> [ 10.104416] input: HDA Intel PCH Front Mic as
> /devices/pci0000:00/0000:00:1f.3/sound/card0/input10
> [ 10.104441] input: HDA Intel PCH Line as
> /devices/pci0000:00/0000:00:1f.3/sound/card0/input11
> [ 10.104467] input: HDA Intel PCH Line Out as
> /devices/pci0000:00/0000:00:1f.3/sound/card0/input12
> [ 10.104494] input: HDA Intel PCH Front Headphone as
> /devices/pci0000:00/0000:00:1f.3/sound/card0/input13
>
> Consequently, I checked the pin widgets' default configuration values:
> - Node 0x14 [Pin Complex] wcaps 0x40058d: Stereo Amp-Out
> Pin Default 0x01014010: [Jack] Line Out at Ext Rear
>
> - Node 0x1b [Pin Complex] wcaps 0x40058f: Stereo Amp-In Amp-Out
> Pin Default 0x02214030: [Jack] HP Out at Ext Front
>
> Because the headphone jack (Node ID:0x1b) locates on the desktop's front
> panel, not rear panel, I change the headphone jack's configuration from
> primary chassis to separate chassis. So, the configuration value of
> Node ID:0x1b should be 0x22214030.
This is OK, but...
> Additionally, I toggle the Auto-Mute Mode of Realtek codecs to “Speaker
> Only” which makes signal outputs through line out jack when the "Line
> Out" is chosen in the sound settings.
... this is a matter of taste, and I don't think it good to set a
different default from others. You can change it once and save it via
alsactl.
And, the code to change this doesn't look good, either. If any, it'd
be easier to just set spec->gen.automute_speaker and
spec->gen.automute_lo in the fixup with HDA_FIXUP_ACT_PROBE (that is
performed after the parser call).
So, for now, I prefer having a change only touching the pinconfig.
Care to resend the reduced one?
thanks,
Takashi
>
> Signed-off-by: Jian-Hong Pan <jian-hong@...lessm.com>
> ---
> sound/pci/hda/patch_realtek.c | 34 ++++++++++++++++++++++++++++++++++
> 1 file changed, 34 insertions(+)
>
> diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
> index aef1f52db7d9..a066d84c6478 100644
> --- a/sound/pci/hda/patch_realtek.c
> +++ b/sound/pci/hda/patch_realtek.c
> @@ -1810,6 +1810,8 @@ enum {
> ALC887_FIXUP_BASS_CHMAP,
> ALC1220_FIXUP_GB_DUAL_CODECS,
> ALC1220_FIXUP_CLEVO_P950,
> + ALC887_FIXUP_ASUS_AUTOMUTE_MODE,
> + ALC887_FIXUP_ASUS_FRONT_HP,
> };
>
> static void alc889_fixup_coef(struct hda_codec *codec,
> @@ -2044,6 +2046,24 @@ static void alc1220_fixup_clevo_p950(struct hda_codec *codec,
> snd_hda_override_conn_list(codec, 0x1b, 1, conn1);
> }
>
> +/* fix the default Auto-Mute Mode in mixer */
> +static void alc887_fixup_asus_automute_mode(struct hda_codec *codec,
> + const struct hda_fixup *fix, int action)
> +{
> + struct snd_kcontrol *kctl;
> + struct snd_ctl_elem_value *uctl;
> +
> + kctl = snd_hda_find_mixer_ctl(codec, "Auto-Mute Mode");
> + if (!kctl)
> + return;
> + uctl = kzalloc(sizeof(*uctl), GFP_KERNEL);
> + if (!uctl)
> + return;
> + uctl->value.enumerated.item[0] = 1;
> + kctl->put(kctl, uctl);
> + kfree(uctl);
> +}
> +
> static const struct hda_fixup alc882_fixups[] = {
> [ALC882_FIXUP_ABIT_AW9D_MAX] = {
> .type = HDA_FIXUP_PINS,
> @@ -2288,6 +2308,19 @@ static const struct hda_fixup alc882_fixups[] = {
> .type = HDA_FIXUP_FUNC,
> .v.func = alc1220_fixup_clevo_p950,
> },
> + [ALC887_FIXUP_ASUS_AUTOMUTE_MODE] = {
> + .type = HDA_FIXUP_FUNC,
> + .v.func = alc887_fixup_asus_automute_mode,
> + },
> + [ALC887_FIXUP_ASUS_FRONT_HP] = {
> + .type = HDA_FIXUP_PINS,
> + .v.pins = (const struct hda_pintbl[]) {
> + {0x1b, 0x22214030},
> + {}
> + },
> + .chained = true,
> + .chain_id = ALC887_FIXUP_ASUS_AUTOMUTE_MODE,
> + },
> };
>
> static const struct snd_pci_quirk alc882_fixup_tbl[] = {
> @@ -2321,6 +2354,7 @@ static const struct snd_pci_quirk alc882_fixup_tbl[] = {
> SND_PCI_QUIRK(0x1043, 0x13c2, "Asus A7M", ALC882_FIXUP_EAPD),
> SND_PCI_QUIRK(0x1043, 0x1873, "ASUS W90V", ALC882_FIXUP_ASUS_W90V),
> SND_PCI_QUIRK(0x1043, 0x1971, "Asus W2JC", ALC882_FIXUP_ASUS_W2JC),
> + SND_PCI_QUIRK(0x1043, 0x2160, "ASUSPRO D640MB", ALC887_FIXUP_ASUS_FRONT_HP),
> SND_PCI_QUIRK(0x1043, 0x835f, "Asus Eee 1601", ALC888_FIXUP_EEE1601),
> SND_PCI_QUIRK(0x1043, 0x84bc, "ASUS ET2700", ALC887_FIXUP_ASUS_BASS),
> SND_PCI_QUIRK(0x1043, 0x8691, "ASUS ROG Ranger VIII", ALC882_FIXUP_GPIO3),
> --
> 2.11.0
>
>
Powered by blists - more mailing lists