linux-kernel - Re: [PATCH] scsi: hosts: remove redundant assingment of shost->use_blk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4c62b8f8da1175ddcdcdf0a234dacbf620d73060.camel@wdc.com>
Date:   Mon, 2 Apr 2018 13:53:08 +0000
From:   Bart Van Assche <Bart.VanAssche@....com>
To:     "jthumshirn@...e.de" <jthumshirn@...e.de>,
        "martin.petersen@...cle.com" <martin.petersen@...cle.com>
CC:     "linux-scsi@...r.kernel.org" <linux-scsi@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] scsi: hosts: remove redundant assingment of
 shost->use_blk_mq

On Mon, 2018-04-02 at 11:37 +0200, Johannes Thumshirn wrote:
> Coverity reports that we're assigning shost->use_blk_mq twice. This
> looks like the result of a bad merge of commit 2f31115e940c ("scsi:
> core: introduce force_blk_mq")
> 
> Signed-off-by: Johannes Thumshirn <jthumshirn@...e.de>
> ---
>  drivers/scsi/hosts.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/scsi/hosts.c b/drivers/scsi/hosts.c
> index ef22b275d050..c36f2a44e5ed 100644
> --- a/drivers/scsi/hosts.c
> +++ b/drivers/scsi/hosts.c
> @@ -473,7 +473,6 @@ struct Scsi_Host *scsi_host_alloc(struct scsi_host_template *sht, int privsize)
>  	else
>  		shost->dma_boundary = 0xffffffff;
>  
> -	shost->use_blk_mq = scsi_use_blk_mq;
>  	shost->use_blk_mq = scsi_use_blk_mq || shost->hostt->force_blk_mq;
>  
>  	device_initialize(&shost->shost_gendev);

A similar patch has already been queued by Martin. See also
https://patchwork.kernel.org/patch/10313569/.

Bart.