linux-kernel - Re: [PATCH v2] serial: 8250: omap: Provide ability to enable/disable UART as wakeup source

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 2 Apr 2018 17:01:22 +0300
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     Vignesh R <vigneshr@...com>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Jiri Slaby <jslaby@...e.com>, Tony Lindgren <tony@...mide.com>,
        "open list:SERIAL DRIVERS" <linux-serial@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Linux OMAP Mailing List <linux-omap@...r.kernel.org>
Subject: Re: [PATCH v2] serial: 8250: omap: Provide ability to enable/disable
 UART as wakeup source

On Mon, Apr 2, 2018 at 3:20 PM, Vignesh R <vigneshr@...com> wrote:

> +       pm_runtime_get_sync(dev);

> +       if (!device_may_wakeup(dev))
> +               priv->wer = 0;

Can it be

priv->wer = device_may_wakeup(dev);

?

> +       serial_out(up, UART_OMAP_WER, priv->wer);
> +       pm_runtime_mark_last_busy(dev);
> +       pm_runtime_put_autosuspend(dev);

-- 
With Best Regards,
Andy Shevchenko