linux-kernel - Re: [PATCH] Fixed some style warnings and errors

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20180402164333.GB21609@pd.tnic>
Date:   Mon, 2 Apr 2018 18:43:33 +0200
From:   Borislav Petkov <bp@...en8.de>
To:     Khan M Rashedun-Naby <naby88@...il.com>
Cc:     tglx@...utronix.de, mingo@...hat.com, hpa@...or.com,
        x86@...nel.org, thomas.lendacky@....com, jgross@...e.com,
        r.marek@...embler.cz, qianyue.zj@...baba-inc.com,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Fixed some style warnings and errors

On Mon, Apr 02, 2018 at 10:24:36PM +0600, Khan M Rashedun-Naby wrote:
> Thanks Borislav, but what about the data type fix ? :)

First of all, please do not top-post when replying to lkml email and
also, when replying, hit reply-to-all so that all the people on CC can
get the answer. I've fixed that now.

For a more detailed discussion on the whole process, take a look at

Documentation/process/

or alternatively at a well-formatted version:

https://www.kernel.org/doc/html/latest/process/index.html

Now to your question: forget the "data type fix" - that will be
addressed when we touch that code at some point anyway. Pure checkpatch
patches only dilute git history and don't really help.

If you really want to get involved, try fixing real
bugs like fixing drivers in staging, for example.
https://kernelnewbies.org/FirstKernelPatch has a very detailed
explanation how to do that.

HTH.

-- 
Regards/Gruss,
    Boris.

Good mailing practices for 400: avoid top-posting and trim the reply.