linux-kernel - Re: [PATCH v3 5/6] Initialize the mapping of KASan shadow memory

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 2 Apr 2018 14:08:13 -0400 (EDT)
From:   Nicolas Pitre <nicolas.pitre@...aro.org>
To:     Abbott Liu <liuwenliang@...wei.com>
cc:     aryabinin@...tuozzo.com, dvyukov@...gle.com,
        Jonathan Corbet <corbet@....net>,
        Russell King - ARM Linux <linux@...linux.org.uk>,
        christoffer.dall@...aro.org, marc.zyngier@....com,
        kstewart@...uxfoundation.org, gregkh@...uxfoundation.org,
        f.fainelli@...il.com, Andrew Morton <akpm@...ux-foundation.org>,
        linux@...musvillemoes.dk, mawilcox@...rosoft.com,
        pombredanne@...b.com, ard.biesheuvel@...aro.org,
        vladimir.murzin@....com, alexander.levin@...izon.com,
        tglx@...utronix.de, thgarnie@...gle.com, dhowells@...hat.com,
        keescook@...omium.org, Arnd Bergmann <arnd@...db.de>,
        geert@...ux-m68k.org, tixy@...aro.org, julien.thierry@....com,
        mark.rutland@....com, james.morse@....com,
        zhichao.huang@...aro.org, jinb.park7@...il.com, labbott@...hat.com,
        philip@....systems, grygorii.strashko@...aro.org,
        Catalin Marinas <catalin.marinas@....com>, opendmb@...il.com,
        kirill.shutemov@...ux.intel.com, kasan-dev@...glegroups.com,
        linux-doc@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org, kvmarm@...ts.cs.columbia.edu,
        linux-mm@...ck.org
Subject: Re: [PATCH v3 5/6] Initialize the mapping of KASan shadow memory

On Mon, 2 Apr 2018, Abbott Liu wrote:

> index c79b829..20161e2 100644
> --- a/arch/arm/kernel/head-common.S
> +++ b/arch/arm/kernel/head-common.S
> @@ -115,6 +115,9 @@ __mmap_switched:
>  	str	r8, [r2]			@ Save atags pointer
>  	cmp	r3, #0
>  	strne	r10, [r3]			@ Save control register values
> +#ifdef CONFIG_KASAN
> +	bl	kasan_early_init
> +#endif
>  	mov	lr, #0
>  	b	start_kernel
>  ENDPROC(__mmap_switched)

Would be better if lr was cleared before calling kasan_early_init.


Nicolas