linux-kernel - Re: [PATCH v3 5/6] Initialize the mapping of KASan shadow memory

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <nycvar.YSQ.7.76.1804021418220.28462@knanqh.ubzr>
Date:   Mon, 2 Apr 2018 14:20:15 -0400 (EDT)
From:   Nicolas Pitre <nicolas.pitre@...aro.org>
To:     Russell King - ARM Linux <linux@...linux.org.uk>
cc:     Abbott Liu <liuwenliang@...wei.com>, kstewart@...uxfoundation.org,
        tixy@...aro.org, grygorii.strashko@...aro.org,
        julien.thierry@....com, Catalin Marinas <catalin.marinas@....com>,
        linux@...musvillemoes.dk, dhowells@...hat.com, linux-mm@...ck.org,
        mark.rutland@....com, kvmarm@...ts.cs.columbia.edu,
        f.fainelli@...il.com, Jonathan Corbet <corbet@....net>,
        linux-doc@...r.kernel.org, kasan-dev@...glegroups.com,
        geert@...ux-m68k.org, linux-arm-kernel@...ts.infradead.org,
        zhichao.huang@...aro.org, aryabinin@...tuozzo.com,
        labbott@...hat.com, vladimir.murzin@....com, keescook@...omium.org,
        Arnd Bergmann <arnd@...db.de>, marc.zyngier@....com,
        philip@....systems, jinb.park7@...il.com, opendmb@...il.com,
        tglx@...utronix.de, dvyukov@...gle.com, ard.biesheuvel@...aro.org,
        gregkh@...uxfoundation.org, mawilcox@...rosoft.com,
        linux-kernel@...r.kernel.org, alexander.levin@...izon.com,
        james.morse@....com, kirill.shutemov@...ux.intel.com,
        pombredanne@...b.com, Andrew Morton <akpm@...ux-foundation.org>,
        thgarnie@...gle.com, christoffer.dall@...aro.org
Subject: Re: [PATCH v3 5/6] Initialize the mapping of KASan shadow memory

On Mon, 2 Apr 2018, Russell King - ARM Linux wrote:

> On Mon, Apr 02, 2018 at 02:08:13PM -0400, Nicolas Pitre wrote:
> > On Mon, 2 Apr 2018, Abbott Liu wrote:
> > 
> > > index c79b829..20161e2 100644
> > > --- a/arch/arm/kernel/head-common.S
> > > +++ b/arch/arm/kernel/head-common.S
> > > @@ -115,6 +115,9 @@ __mmap_switched:
> > >  	str	r8, [r2]			@ Save atags pointer
> > >  	cmp	r3, #0
> > >  	strne	r10, [r3]			@ Save control register values
> > > +#ifdef CONFIG_KASAN
> > > +	bl	kasan_early_init
> > > +#endif
> > >  	mov	lr, #0
> > >  	b	start_kernel
> > >  ENDPROC(__mmap_switched)
> > 
> > Would be better if lr was cleared before calling kasan_early_init.
> 
> No.  The code is correct - please remember that "bl" writes to LR.

You're right of course.

/me giving up on patch review and going back to bed


Nicolas