linux-kernel - Re: [PATCH] f2fs: fix to show encrypt flag in FS_IOC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180402202105.GB19195@jaegeuk-macbookpro.roam.corp.google.com>
Date:   Mon, 2 Apr 2018 13:21:05 -0700
From:   Jaegeuk Kim <jaegeuk@...nel.org>
To:     Chao Yu <yuchao0@...wei.com>
Cc:     linux-f2fs-devel@...ts.sourceforge.net,
        linux-kernel@...r.kernel.org, chao@...nel.org
Subject: Re: [PATCH] f2fs: fix to show encrypt flag in FS_IOC_GETFLAGS

On 04/02, Chao Yu wrote:
> This patch fixes to show encrypt flag in FS_IOC_GETFLAGS like ext4 does.

Actually, we have to show internal flags owned by f2fs, not generic ones.
We may need to define all of them separately?

> 
> Signed-off-by: Chao Yu <yuchao0@...wei.com>
> ---
>  fs/f2fs/file.c | 9 +++++++--
>  1 file changed, 7 insertions(+), 2 deletions(-)
> 
> diff --git a/fs/f2fs/file.c b/fs/f2fs/file.c
> index 8068b015ece5..271fadadaa36 100644
> --- a/fs/f2fs/file.c
> +++ b/fs/f2fs/file.c
> @@ -1584,8 +1584,13 @@ static int f2fs_ioc_getflags(struct file *filp, unsigned long arg)
>  {
>  	struct inode *inode = file_inode(filp);
>  	struct f2fs_inode_info *fi = F2FS_I(inode);
> -	unsigned int flags = fi->i_flags &
> -			(FS_FL_USER_VISIBLE | FS_PROJINHERIT_FL);
> +	unsigned int flags = fi->i_flags;
> +
> +	if (file_is_encrypt(inode))
> +		flags |= FS_ENCRYPT_FL;
> +
> +	flags &= FS_FL_USER_VISIBLE | FS_PROJINHERIT_FL;
> +
>  	return put_user(flags, (int __user *)arg);
>  }
>  
> -- 
> 2.15.0.55.gc2ece9dc4de6