linux-kernel - Re: [PATCH 3/3] media: i2c: tvp5150: Use parentheses for sizeof

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d5e8dbe4-b68b-ac4e-0076-a3ee995f8327@embeddedor.com>
Date:   Mon, 2 Apr 2018 15:17:37 -0500
From:   "Gustavo A. R. Silva" <garsilva@...eddedor.com>
To:     Nasser Afshin <afshin.nasser@...il.com>, mchehab@...nel.org
Cc:     Sakari Ailus <sakari.ailus@...ux.intel.com>,
        Hans Verkuil <hans.verkuil@...co.com>,
        Philipp Zabel <p.zabel@...gutronix.de>,
        linux-media@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 3/3] media: i2c: tvp5150: Use parentheses for sizeof

Hi,

On 04/02/2018 02:59 PM, Nasser Afshin wrote:
> This patch resolves a checkpatch.pl warning

It would be nice if you explicitly mention the warning.

Thanks.
--
Gustavo

> Signed-off-by: Nasser Afshin <Afshin.Nasser@...il.com>
> ---
>   drivers/media/i2c/tvp5150.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/media/i2c/tvp5150.c b/drivers/media/i2c/tvp5150.c
> index d561d87d219a..d528fddbea16 100644
> --- a/drivers/media/i2c/tvp5150.c
> +++ b/drivers/media/i2c/tvp5150.c
> @@ -625,7 +625,7 @@ static int tvp5150_g_sliced_vbi_cap(struct v4l2_subdev *sd,
>   	int line, i;
>   
>   	dev_dbg_lvl(sd->dev, 1, debug, "g_sliced_vbi_cap\n");
> -	memset(cap, 0, sizeof *cap);
> +	memset(cap, 0, sizeof(*cap));
>   
>   	for (i = 0; i < ARRAY_SIZE(vbi_ram_default); i++) {
>   		const struct i2c_vbi_ram_value *regs = &vbi_ram_default[i];