linux-kernel - Re: [PATCH v2 3/6] drm/msm: Mark the crtc->state->event consumed

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <9fdb112c-7e2e-0f2d-646a-c9ffb3c4c5f8@codeaurora.org>
Date:   Mon, 2 Apr 2018 10:52:44 +0530
From:   Archit Taneja <architt@...eaurora.org>
To:     Sean Paul <seanpaul@...omium.org>, freedreno@...ts.freedesktop.org,
        linux-arm-msm@...r.kernel.org, dri-devel@...ts.freedesktop.org
Cc:     robdclark@...il.com, hoegsberg@...omium.org, jsanka@...eaurora.org,
        abhinavk@...eaurora.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 3/6] drm/msm: Mark the crtc->state->event consumed



On Thursday 29 March 2018 12:36 AM, Sean Paul wrote:
> Don't leave the event != NULL once it's consumed, this is used a signal
s/used a/used as a ?
> to the atomic helpers that the event will be handled by the driver.
>

Reviewed-by: Archit Taneja <architt@...eaurora.org>

> Changes in v2:
> - None
> 
> Cc: Jeykumar Sankaran <jsanka@...eaurora.org>
> Signed-off-by: Sean Paul <seanpaul@...omium.org>
> ---
>   drivers/gpu/drm/msm/disp/mdp4/mdp4_crtc.c | 1 +
>   drivers/gpu/drm/msm/disp/mdp5/mdp5_crtc.c | 1 +
>   2 files changed, 2 insertions(+)
> 
> diff --git a/drivers/gpu/drm/msm/disp/mdp4/mdp4_crtc.c b/drivers/gpu/drm/msm/disp/mdp4/mdp4_crtc.c
> index 6e5e1aa54ce1..b001699297c4 100644
> --- a/drivers/gpu/drm/msm/disp/mdp4/mdp4_crtc.c
> +++ b/drivers/gpu/drm/msm/disp/mdp4/mdp4_crtc.c
> @@ -351,6 +351,7 @@ static void mdp4_crtc_atomic_flush(struct drm_crtc *crtc,
>   
>   	spin_lock_irqsave(&dev->event_lock, flags);
>   	mdp4_crtc->event = crtc->state->event;
> +	crtc->state->event = NULL;
>   	spin_unlock_irqrestore(&dev->event_lock, flags);
>   
>   	blend_setup(crtc);
> diff --git a/drivers/gpu/drm/msm/disp/mdp5/mdp5_crtc.c b/drivers/gpu/drm/msm/disp/mdp5/mdp5_crtc.c
> index 9893e43ba6c5..76b96081916f 100644
> --- a/drivers/gpu/drm/msm/disp/mdp5/mdp5_crtc.c
> +++ b/drivers/gpu/drm/msm/disp/mdp5/mdp5_crtc.c
> @@ -708,6 +708,7 @@ static void mdp5_crtc_atomic_flush(struct drm_crtc *crtc,
>   
>   	spin_lock_irqsave(&dev->event_lock, flags);
>   	mdp5_crtc->event = crtc->state->event;
> +	crtc->state->event = NULL;
>   	spin_unlock_irqrestore(&dev->event_lock, flags);
>   
>   	/*
>