linux-kernel - Re: [RESEND] rtc: snvs: Fix usage of snvs_rtc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4f9434c7-6977-caef-2fac-5da79364304b@nexus-software.ie>
Date:   Mon, 2 Apr 2018 23:51:12 +0100
From:   Bryan O'Donoghue <pure.logic@...us-software.ie>
To:     Trent Piepho <tpiepho@...inj.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "alexandre.belloni@...e-electrons.com" 
        <alexandre.belloni@...e-electrons.com>
Cc:     "shawn.guo@...aro.org" <shawn.guo@...aro.org>,
        "stefan@...er.ch" <stefan@...er.ch>,
        "bianpan2016@....com" <bianpan2016@....com>,
        "a.zummo@...ertech.it" <a.zummo@...ertech.it>,
        "stable@...r.kernel.org" <stable@...r.kernel.org>,
        "guy.shapiro@...i-wize.com" <guy.shapiro@...i-wize.com>,
        "Frank.Li@...escale.com" <Frank.Li@...escale.com>,
        "linux-rtc@...r.kernel.org" <linux-rtc@...r.kernel.org>
Subject: Re: [RESEND] rtc: snvs: Fix usage of snvs_rtc_enable

On 30/03/18 23:59, Trent Piepho wrote:
> However, I think that even if the driver fails to probe if there is a
> timeout at probe time, it's still possible to hang later if there are
> not limits to the hardware polling loops, such as the ones I added.

I agree with your patch in principle for this the reason you've outlined.

My patch though should still be applied to fix non-starting @ source.

/aside - I don't have your patch in my inbox - if you could resend and 
cc me I'll review it for you.

---
bod