linux-kernel - Re: 答复: Re: [PATCH v2] scsi: Introduce sdev_printk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5AC1C8BF.1030503@huawei.com>
Date:   Mon, 2 Apr 2018 14:07:59 +0800
From:   Jason Yan <yanaijie@...wei.com>
To:     Sergey Senozhatsky <sergey.senozhatsky.work@...il.com>,
        <wen.yang99@....com.cn>
CC:     <jejb@...ux.vnet.ibm.com>, <martin.petersen@...cle.com>,
        <linux-scsi@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <Bart.VanAssche@....com>, <pmladek@...e.com>, <tj@...nel.org>,
        <jiang.biao2@....com.cn>, <zhong.weidong@....com.cn>,
        <tan.hu@....com.cn>
Subject: Re: 答复: Re: [PATCH v2] scsi: Introduce sdev_printk_ratelimited to throttlefrequent printk



On 2018/4/2 13:29, Sergey Senozhatsky wrote:
> On (04/02/18 13:14), wen.yang99@....com.cn wrote:
>>
>>     > It's true that this print for the same device is useless. But it's
>>     > useful for different devices. Is it possible to limit the print only
>>     > for the same device?
>>
>>     In our scene, it's  just for the same device (q->queuedata), Thanks.
>
> Yes, what Jason meant was that rate limit struct is shared by different call
> sites - including scsi_request_fn() from different devices.
>
> If device1->scsi_request_fn()->sdev_printk_ratelimited() causes printk rate
> limit, then messages from device2->scsi_request_fn()->sdev_printk_ratelimited()
> may be lost entirely, unless you have enough of them.
>
> 	-ss
>

Yes, that's exactly what I mean.

Thanks,

Jason

> .
>