linux-kernel - Re: BUG: corrupted list in __dentry

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180402064437.GB30522@ZenIV.linux.org.uk>
Date:   Mon, 2 Apr 2018 07:44:37 +0100
From:   Al Viro <viro@...IV.linux.org.uk>
To:     Eric Biggers <ebiggers3@...il.com>
Cc:     syzbot <syzbot+f3bd89a5ab3266b10540@...kaller.appspotmail.com>,
        linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org,
        syzkaller-bugs@...glegroups.com, linux-nfs@...r.kernel.org
Subject: Re: BUG: corrupted list in __dentry_kill

On Sun, Apr 01, 2018 at 02:48:54PM -0700, Eric Biggers wrote:
> [+Cc linux-nfs]
> > 
> > [   42.965515] net/sunrpc/rpc_pipe.c: __rpc_create_common failed to allocate inode for dentry blocklayout
> > [   42.967234] net/sunrpc/rpc_pipe.c: rpc_mkpipe_dentry() failed to create pipe nfs/blocklayout (errno = -12)

	AFAICS, there's nothing to zero nn->bl_device_pipe->dentry after
nfs4blocklayout_unregister_sb(), is there?  If nothing else, what's
going to happen after mount/umount/mount with failing
nfs4blocklayout_register_sb()?  AFAICS, we'll have stale pointer to
dentry sitting in nn->bl_device_pipe->dentry, and call rpc_unlink()
on it while cleaning up after the failing mount.

	I don't think that's all there is to it, but it does smell like
a bug.