linux-kernel - Re: [PATCH v3 2/6] Disable instrumentation for some code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20180403113837.GK16141@n2100.armlinux.org.uk>
Date:   Tue, 3 Apr 2018 12:38:37 +0100
From:   Russell King - ARM Linux <linux@...linux.org.uk>
To:     Marc Zyngier <marc.zyngier@....com>
Cc:     Abbott Liu <liuwenliang@...wei.com>, aryabinin@...tuozzo.com,
        dvyukov@...gle.com, corbet@....net, christoffer.dall@...aro.org,
        kstewart@...uxfoundation.org, gregkh@...uxfoundation.org,
        f.fainelli@...il.com, akpm@...ux-foundation.org,
        linux@...musvillemoes.dk, mawilcox@...rosoft.com,
        pombredanne@...b.com, ard.biesheuvel@...aro.org,
        vladimir.murzin@....com, alexander.levin@...izon.com,
        nicolas.pitre@...aro.org, tglx@...utronix.de, thgarnie@...gle.com,
        dhowells@...hat.com, keescook@...omium.org, arnd@...db.de,
        geert@...ux-m68k.org, tixy@...aro.org, julien.thierry@....com,
        mark.rutland@....com, james.morse@....com,
        zhichao.huang@...aro.org, jinb.park7@...il.com, labbott@...hat.com,
        philip@....systems, grygorii.strashko@...aro.org,
        catalin.marinas@....com, opendmb@...il.com,
        kirill.shutemov@...ux.intel.com, kasan-dev@...glegroups.com,
        linux-doc@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org, kvmarm@...ts.cs.columbia.edu,
        linux-mm@...ck.org
Subject: Re: [PATCH v3 2/6] Disable instrumentation for some code

On Tue, Apr 03, 2018 at 12:30:42PM +0100, Marc Zyngier wrote:
> On 02/04/18 13:04, Abbott Liu wrote:
> > From: Andrey Ryabinin <a.ryabinin@...sung.com>
> > 
> > Disable instrumentation for arch/arm/boot/compressed/*
> > ,arch/arm/kvm/hyp/* and arch/arm/vdso/* because those
> > code won't linkd with kernel image.
> > 
> > Disable kasan check in the function unwind_pop_register
> > because it doesn't matter that kasan checks failed when
> > unwind_pop_register read stack memory of task.
> > 
> > Reviewed-by: Russell King - ARM Linux <linux@...linux.org.uk>
> > Reviewed-by: Florian Fainelli <f.fainelli@...il.com>
> > Reviewed-by: Marc Zyngier <marc.zyngier@....com>
> 
> Just because I replied to this patch doesn't mean you can stick my
> Reviewed-by tag on it. Please drop this tag until I explicitly say that
> you can add it (see Documentation/process/submitting-patches.rst,
> section 11).
> 
> Same goes for patch 1.

Same goes for that reviewed-by line for me.  From my records, I never
even looked at patch 2 from the first posting, and I don't appear to
have the second posting in my mailbox (it's probably been classed as
spam by dspam.)  So these reviewed-by lines seem to be totally
misleading.

-- 
RMK's Patch system: http://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line in suburbia: sync at 8.8Mbps down 630kbps up
According to speedtest.net: 8.21Mbps down 510kbps up