linux-kernel - Re: [PATCH 4.4 70/97] rtc: ds1374: wdt: Fix issue with timeout scaling from secs to wdt ticks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1522791985.2654.142.camel@codethink.co.uk>
Date:   Tue, 03 Apr 2018 22:46:25 +0100
From:   Ben Hutchings <ben.hutchings@...ethink.co.uk>
To:     Moritz Fischer <mdf@...nel.org>,
        Alexandre Belloni <alexandre.belloni@...e-electrons.com>
Cc:     stable@...r.kernel.org,
        Sasha Levin <alexander.levin@...rosoft.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 4.4 70/97] rtc: ds1374: wdt: Fix issue with timeout
 scaling from secs to wdt ticks

On Fri, 2018-03-23 at 10:54 +0100, Greg Kroah-Hartman wrote:
> 4.4-stable review patch.  If anyone has any objections, please let me know.
> 
> ------------------
> 
> From: Moritz Fischer <mdf@...nel.org>
> 
> 
> [ Upstream commit 453d0744f6c6ca3f9749b8c57c2e85b5b9f52514 ]
> 
> The issue is that the internal counter that triggers the watchdog reset
> is actually running at 4096 Hz instead of 1Hz, therefore the value
> given by userland (in sec) needs to be multiplied by 4096 to get the
> correct behavior.
[...]

The wdt_margin module parameter has the same problem.

Ben.

-- 
Ben Hutchings
Software Developer, Codethink Ltd.