linux-kernel - Re: [PATCH v2] tools include: define READ_ONCE/WRITE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <ddeec38a-3843-b812-7219-7e4fef8f040f@linux.vnet.ibm.com>
Date:   Wed, 4 Apr 2018 11:46:38 +0530
From:   Sandipan Das <sandipan@...ux.vnet.ibm.com>
To:     linux-kernel@...r.kernel.org
Cc:     Li Zhijian <lizhijian@...fujitsu.com>, acme@...hat.com,
        philip.li@...el.com, mark.rutland@....com,
        paulmck@...ux.vnet.ibm.com, mingo@...nel.org
Subject: Re: [PATCH v2] tools include: define READ_ONCE/WRITE_ONCE for C++

Hi,

On 11/30/2017 07:06 AM, Li Zhijian wrote:
> since 6aa7de0, we failed to build perf with C++(clang)
> to fix the following compile errors
> --------------
> lizhijian@...well-OptiPlex-9020:~/lkp/linux/tools/perf$ make LLVM_CONFIG=/usr/bin/llvm-config-3.9 LIBCLANGLLVM=1
> ...
>   CC       util/probe-finder.o
> In file included from /home/lizj/linux/tools/perf/util/util.h:13:0,
>                  from /home/lizj/linux/tools/perf/util/util-cxx.h:20,
>                  from util/c++/clang-c.h:5,
>                  from util/c++/clang-test.cpp:2:
> /home/lizj/linux/tools/include/asm/../../arch/x86/include/asm/atomic.h: In function ‘int atomic_read(const atomic_t*)’:
> /home/lizj/linux/tools/include/linux/compiler.h:157:45: error: use of deleted function ‘atomic_read(const atomic_t*)::<anonymous union>::<constructor>()’
>   ({ union { typeof(x) __val; char __c[1]; } __u; __read_once_size(&(x), __u.__c, sizeof(x)); __u.__val; })
>                                              ^
> /home/lizj/linux/tools/include/asm/../../arch/x86/include/asm/atomic.h:28:9: note: in expansion of macro ‘READ_ONCE’
>   return READ_ONCE((v)->counter);
>          ^
> /home/lizj/linux/tools/include/linux/compiler.h:157:11: note: ‘atomic_read(const atomic_t*)::<anonymous union>::<constructor>()’ is implicitly deleted because the default definition would be ill-formed:
>   ({ union { typeof(x) __val; char __c[1]; } __u; __read_once_size(&(x), __u.__c, sizeof(x)); __u.__val; })
>            ^
> /home/lizj/linux/tools/include/asm/../../arch/x86/include/asm/atomic.h:28:9: note: in expansion of macro ‘READ_ONCE’
>   return READ_ONCE((v)->counter);
>          ^
> /home/lizj/linux/tools/include/linux/compiler.h:157:11: error: uninitialized const member in ‘union atomic_read(const atomic_t*)::<anonymous>’
>   ({ union { typeof(x) __val; char __c[1]; } __u; __read_once_size(&(x), __u.__c, sizeof(x)); __u.__val; })
>            ^
> /home/lizj/linux/tools/include/asm/../../arch/x86/include/asm/atomic.h:28:9: note: in expansion of macro ‘READ_ONCE’
>   return READ_ONCE((v)->counter);
>          ^
> /home/lizj/linux/tools/include/linux/compiler.h:157:23: note: ‘const int atomic_read(const atomic_t*)::<anonymous union>::__val’ should be initialized
>   ({ union { typeof(x) __val; char __c[1]; } __u; __read_once_size(&(x), __u.__c, sizeof(x)); __u.__val; })
>                        ^
> /home/lizj/linux/tools/include/asm/../../arch/x86/include/asm/atomic.h:28:9: note: in expansion of macro ‘READ_ONCE’
>   return READ_ONCE((v)->counter);
>          ^
>   LD       tests/perf-in.o
> ...
> --------------
> 

I ran into the same problems while building perf with clang support.
If the solution proposed here is acceptable, can someone please pick
up this patch?

--
With Regards,
Sandipan