linux-kernel - Re: [PATCH] kernel/bpf/syscall: fix warning defined but not used

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <327e3c1f-860b-e2b4-7475-34a409c62fae@iogearbox.net>
Date:   Wed, 4 Apr 2018 11:15:29 +0200
From:   Daniel Borkmann <daniel@...earbox.net>
To:     Anders Roxell <anders.roxell@...aro.org>, ast@...nel.org
Cc:     netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] kernel/bpf/syscall: fix warning defined but not used

On 04/03/2018 02:09 PM, Anders Roxell wrote:
> There will be a build warning -Wunused-function if CONFIG_CGROUP_BPF
> isn't defined, since the only user is inside #ifdef CONFIG_CGROUP_BPF:
> kernel/bpf/syscall.c:1229:12: warning: ‘bpf_prog_attach_check_attach_type’
>     defined but not used [-Wunused-function]
>  static int bpf_prog_attach_check_attach_type(const struct bpf_prog *prog,
>             ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> 
> Current code moves function bpf_prog_attach_check_attach_type inside
> ifdef CONFIG_CGROUP_BPF.
> 
> Fixes: 5e43f899b03a ("bpf: Check attach type at prog load time")
> Signed-off-by: Anders Roxell <anders.roxell@...aro.org>

Applied to bpf tree, thanks Anders!