[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Wed, 4 Apr 2018 12:56:19 +0100
From: Gustavo Pimentel <gustavo.pimentel@...opsys.com>
To: Lorenzo Pieralisi <lorenzo.pieralisi@....com>
Cc: "bhelgaas@...gle.com" <bhelgaas@...gle.com>,
"Joao.Pinto@...opsys.com" <Joao.Pinto@...opsys.com>,
"jingoohan1@...il.com" <jingoohan1@...il.com>,
"kishon@...com" <kishon@...com>,
"robh+dt@...nel.org" <robh+dt@...nel.org>,
"mark.rutland@....com" <mark.rutland@....com>,
"linux-pci@...r.kernel.org" <linux-pci@...r.kernel.org>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>
Subject: Re: [PATCH 3/8] bindings: PCI: designware: Add support for the EP in
designware driver
Hi Lorenzo,
On 04/04/2018 12:50, Lorenzo Pieralisi wrote:
> On Wed, Mar 28, 2018 at 12:38:33PM +0100, Gustavo Pimentel wrote:
>
> Please always write a commit log even if it is trivial.
Ok, Kishon has also refered that. On next patch version it'll contain a log
description.
>
> Thanks,
> Lorenzo
>
>> Signed-off-by: Gustavo Pimentel <gustavo.pimentel@...opsys.com>
>> ---
>> Documentation/devicetree/bindings/pci/designware-pcie.txt | 13 +++++++++++++
>> 1 file changed, 13 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/pci/designware-pcie.txt b/Documentation/devicetree/bindings/pci/designware-pcie.txt
>> index 6300762..4bb2e08 100644
>> --- a/Documentation/devicetree/bindings/pci/designware-pcie.txt
>> +++ b/Documentation/devicetree/bindings/pci/designware-pcie.txt
>> @@ -3,6 +3,7 @@
>> Required properties:
>> - compatible:
>> "snps,dw-pcie" for RC mode;
>> + "snps,dw-pcie-ep" for EP mode;
>> - reg: Should contain the configuration address space.
>> - reg-names: Must be "config" for the PCIe configuration space.
>> (The old way of getting the configuration address space from "ranges"
>> @@ -56,3 +57,15 @@ Example configuration:
>> #interrupt-cells = <1>;
>> num-lanes = <1>;
>> };
>> +or
>> + pcie_ep: pcie_ep@...00000 {
>> + compatible = "snps,dw-pcie-ep";
>> + reg = <0xdfc00000 0x0001000>, /* IP registers 1 */
>> + <0xdfc01000 0x0001000>, /* IP registers 2 */
>> + <0xd0000000 0x2000000>; /* Configuration space */
>> + reg-names = "dbi", "dbi2", "addr_space";
>> + device_type = "pci";
>> + num-ib-windows = <6>;
>> + num-ob-windows = <2>;
>> + num-lanes = <1>;
>> + };
>> --
>> 2.7.4
>>
>>
Regards,
Gustavo
Powered by blists - more mailing lists