linux-kernel - Re: [PATCH v2] lan78xx: Connect phy early

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 04 Apr 2018 11:41:56 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     agraf@...e.de
Cc:     netdev@...r.kernel.org, linux-usb@...r.kernel.org,
        linux-kernel@...r.kernel.org, Nisar.Sayed@...rochip.com,
        Woojung.Huh@...rochip.com, UNGLinuxDriver@...rochip.com,
        tbogendoerfer@...e.de, phil@...pberrypi.org, andrew@...n.ch,
        RaghuramChary.Jallipalli@...rochip.com
Subject: Re: [PATCH v2] lan78xx: Connect phy early

From: Alexander Graf <agraf@...e.de>
Date: Wed,  4 Apr 2018 00:19:35 +0200

> When using wicked with a lan78xx device attached to the system, we
> end up with ethtool commands issued on the device before an ifup
> got issued. That lead to the following crash:
> 
 ...
> The culprit is quite simple: The driver tries to access the phy left and right,
> but only actually has a working reference to it when the device is up.
> 
> The fix thus is quite simple too: Get a reference to the phy on probe already
> and keep it even when the device is going down.
> 
> With this patch applied, I can successfully run wicked on my system and bring
> the interface up and down as many times as I want, without getting NULL pointer
> dereferences in between.
> 
> Signed-off-by: Alexander Graf <agraf@...e.de>

Applied, thank you.