linux-kernel - Re: [PATCH] kvm: Add emulation for movups/movupd

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 4 Apr 2018 17:53:04 +0200
From:   Paolo Bonzini <pbonzini@...hat.com>
To:     Stefan Fritsch <sf@...itsch.de>,
        Radim Krčmář <rkrcmar@...hat.com>,
        Thomas Gleixner <tglx@...utronix.de>,
        Ingo Molnar <mingo@...hat.com>,
        "H. Peter Anvin" <hpa@...or.com>, x86@...nel.org,
        kvm@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] kvm: Add emulation for movups/movupd

On 01/04/2018 17:54, Stefan Fritsch wrote:
> This is very similar to the aligned versions movaps/movapd.
> 
> We have seen the corresponding emulation failures with openbsd as guest
> and with Windows 10 with intel HD graphics pass through.
> 
> Signed-off-by: Christian Ehrhardt <christian_ehrhardt@...ua.de>
> Signed-off-by: Stefan Fritsch <sf@...itsch.de>
> ---
>  arch/x86/kvm/emulate.c | 8 +++++++-
>  1 file changed, 7 insertions(+), 1 deletion(-)
> 
> diff --git a/arch/x86/kvm/emulate.c b/arch/x86/kvm/emulate.c
> index d91eaeb01034..7dda8e38c19a 100644
> --- a/arch/x86/kvm/emulate.c
> +++ b/arch/x86/kvm/emulate.c
> @@ -4498,6 +4498,10 @@ static const struct gprefix pfx_0f_2b = {
>  	ID(0, &instr_dual_0f_2b), ID(0, &instr_dual_0f_2b), N, N,
>  };
>  
> +static const struct gprefix pfx_0f_10_0f_11 = {
> +	I(Unaligned, em_mov), I(Unaligned, em_mov), N, N,
> +};
> +
>  static const struct gprefix pfx_0f_28_0f_29 = {
>  	I(Aligned, em_mov), I(Aligned, em_mov), N, N,
>  };
> @@ -4709,7 +4713,9 @@ static const struct opcode twobyte_table[256] = {
>  	DI(ImplicitOps | Priv, invd), DI(ImplicitOps | Priv, wbinvd), N, N,
>  	N, D(ImplicitOps | ModRM | SrcMem | NoAccess), N, N,
>  	/* 0x10 - 0x1F */
> -	N, N, N, N, N, N, N, N,
> +	GP(ModRM | DstReg | SrcMem | Mov | Sse, &pfx_0f_10_0f_11),
> +	GP(ModRM | DstMem | SrcReg | Mov | Sse, &pfx_0f_10_0f_11),
> +	N, N, N, N, N, N,
>  	D(ImplicitOps | ModRM | SrcMem | NoAccess),
>  	N, N, N, N, N, N, D(ImplicitOps | ModRM | SrcMem | NoAccess),
>  	/* 0x20 - 0x2F */
> 

Applied, thanks.

Paolo