linux-kernel - Re: [PATCH v2] tracing, printk: Force no hashing when trace

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20180404153039.1c26667b@gandalf.local.home>
Date:   Wed, 4 Apr 2018 15:30:39 -0400
From:   Steven Rostedt <rostedt@...dmis.org>
To:     Linus Torvalds <torvalds@...ux-foundation.org>
Cc:     Sergey Senozhatsky <sergey.senozhatsky.work@...il.com>,
        Kees Cook <keescook@...omium.org>,
        LKML <linux-kernel@...r.kernel.org>,
        "Tobin C. Harding" <me@...in.cc>,
        Andrew Morton <akpm@...ux-foundation.org>,
        David Laight <David.Laight@...lab.com>,
        Peter Zijlstra <peterz@...radead.org>,
        Ingo Molnar <mingo@...nel.org>,
        Thomas Gleixner <tglx@...utronix.de>,
        Petr Mladek <pmladek@...e.com>
Subject: Re: [PATCH v2] tracing, printk: Force no hashing when
 trace_printk() is used

On Wed, 4 Apr 2018 12:04:42 -0700
Linus Torvalds <torvalds@...ux-foundation.org> wrote:


> 
> So at the *very* least this would need to be percpu logic, but even
> that is honestly broken since an NMI might come in and want to printk
> too.
> 
> Why don't you just use %px? That avoids all of these hacks.

Just need to remember to do that. I guess with time it will become
second nature.

> 
> So NAK on this stupid "enable and disable hashing that is
> fundamentally broken" approach.
> 

OK. I'll save the change locally, and add it while debugging kernels.
ktest can do that for me ;-)

-- Steve