lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 4 Apr 2018 10:15:20 +0800 From: Xidong Wang <wangxidong_97@....com> To: "James E . J . Bottomley" <jejb@...ux.vnet.ibm.com>, "Martin K . Petersen" <martin.petersen@...cle.com>, Jack Wang <jinpu.wang@...fitbricks.com>, Johannes Thumshirn <jthumshirn@...e.de>, Peter Senna Tschudin <peter.senna@...labora.com>, Hannes Reinecke <hare@...e.de> Cc: Kees Cook <keescook@...omium.org>, Pan Bian <bianpan2016@....com>, Xidong Wang <wangxidong_97@....com>, Romain Perier <romain.perier@...labora.com>, linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org Subject: [PATCH 1/1] scsi: mvsas:fix memory leak In function mvs_pci_init(), the memory allocated by scsi_host_alloc() is not released on the error path that mvi, which holds the return value of mvs_pci_alloc(), is NULL. This will result in a memory leak bug. Signed-off-by: Xidong Wang <wangxidong_97@....com> --- drivers/scsi/mvsas/mv_init.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/scsi/mvsas/mv_init.c b/drivers/scsi/mvsas/mv_init.c index 8c91637..bde4b50 100644 --- a/drivers/scsi/mvsas/mv_init.c +++ b/drivers/scsi/mvsas/mv_init.c @@ -371,6 +371,7 @@ static struct mvs_info *mvs_pci_alloc(struct pci_dev *pdev, (1L << mvs_chips[ent->driver_data].slot_width) * sizeof(struct mvs_slot_info), GFP_KERNEL); if (!mvi) + scsi_host_put(shost); return NULL; mvi->pdev = pdev; -- 2.7.4
Powered by blists - more mailing lists