linux-kernel - Re: [PATCH v2 2/2] iommu/amd: Add basic debugfs infrastructure for AMD IOMMU

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <201804051607.bYgM8pX0%fengguang.wu@intel.com>
Date:   Thu, 5 Apr 2018 16:12:18 +0800
From:   kbuild test robot <lkp@...el.com>
To:     Gary R Hook <gary.hook@....com>
Cc:     kbuild-all@...org, iommu@...ts.linux-foundation.org,
        joro@...tes.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 2/2] iommu/amd: Add basic debugfs infrastructure for
 AMD IOMMU

Hi Gary,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on iommu/next]
[also build test ERROR on v4.16 next-20180404]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Gary-R-Hook/iommu-Enable-debugfs-exposure-of-the-IOMMU/20180405-151608
base:   https://git.kernel.org/pub/scm/linux/kernel/git/joro/iommu.git next
config: x86_64-randconfig-x002-201813 (attached as .config)
compiler: gcc-7 (Debian 7.3.0-1) 7.3.0
reproduce:
        # save the attached .config to linux build tree
        make ARCH=x86_64 

All error/warnings (new ones prefixed by >>):

   drivers//iommu/amd_iommu_debugfs.c: In function 'amd_iommu_debugfs_setup':
>> drivers//iommu/amd_iommu_debugfs.c:31:11: error: implicit declaration of function 'iommu_debugfs_setup'; did you mean 'amd_iommu_debugfs_setup'? [-Werror=implicit-function-declaration]
      d_top = iommu_debugfs_setup();
              ^~~~~~~~~~~~~~~~~~~
              amd_iommu_debugfs_setup
>> drivers//iommu/amd_iommu_debugfs.c:31:9: warning: assignment makes pointer from integer without a cast [-Wint-conversion]
      d_top = iommu_debugfs_setup();
            ^
   cc1: some warnings being treated as errors

vim +31 drivers//iommu/amd_iommu_debugfs.c

    20	
    21	void amd_iommu_debugfs_setup(struct amd_iommu *iommu)
    22	{
    23		char name[MAX_NAME_LEN + 1];
    24		struct dentry *d_top;
    25	
    26		if (!debugfs_initialized())
    27			return;
    28	
    29		mutex_lock(&amd_iommu_debugfs_lock);
    30		if (!amd_iommu_debugfs) {
  > 31			d_top = iommu_debugfs_setup();

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/gzip" (27655 bytes)