lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:   Thu, 5 Apr 2018 10:51:31 +0200
From:   Paolo Bonzini <>
To:     Wanpeng Li <>
Cc:     David Hildenbrand <>,
        LKML <>, kvm <>,
        Radim Krčmář <>,
        Andrew Cooper <>,
        Konrad Rzeszutek Wilk <>,
        Liran Alon <>
Subject: Re: [PATCH v5 2/2] KVM: X86: Add Force Emulation Prefix for "emulate
 the next instruction"

On 05/04/2018 02:04, Wanpeng Li wrote:
>>> emulate_instruction(vcpu, 0) can handle invalid instruction.
>> But David's observation is still better because your code doesn't handle usermode exits.
> My code handles it, return emulate_instruction(vcpu, 0) ==
> fails.
>> I've fixed this up.
> Thanks. The codes similar to my v3 but more beauty. :) I change to
> this view since Radim's comments to v3

And after I actually woke up I think I disagree with Radim.  Tests can
trap the #UD to test emulation at CPL0 and skip or fail the test for
instructions unknown to the emulator.  It's much better than sending an
emulation failure to userspace, which would abort the guest.


Powered by blists - more mailing lists