linux-kernel - Re: [PATCH 0/8] use struct pt_regs based syscall calling for x86-64

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 5 Apr 2018 17:19:33 +0200
From:   Ingo Molnar <mingo@...nel.org>
To:     Dominik Brodowski <linux@...inikbrodowski.net>
Cc:     linux-kernel@...r.kernel.org, Al Viro <viro@...iv.linux.org.uk>,
        Andi Kleen <ak@...ux.intel.com>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Andy Lutomirski <luto@...nel.org>,
        Brian Gerst <brgerst@...il.com>,
        Denys Vlasenko <dvlasenk@...hat.com>,
        "H. Peter Anvin" <hpa@...or.com>, Ingo Molnar <mingo@...hat.com>,
        Linus Torvalds <torvalds@...ux-foundation.org>,
        Peter Zijlstra <peterz@...radead.org>,
        Thomas Gleixner <tglx@...utronix.de>, x86@...nel.org
Subject: Re: [PATCH 0/8] use struct pt_regs based syscall calling for x86-64


* Dominik Brodowski <linux@...inikbrodowski.net> wrote:

> Dominik Brodowski (7):
>   syscalls: introduce CONFIG_ARCH_HAS_SYSCALL_WRAPPER
>   syscalls/x86: use struct pt_regs based syscall calling for 64-bit
>     syscalls
>   syscalls: prepare ARCH_HAS_SYSCALL_WRAPPER for compat syscalls
>   syscalls/x86: use struct pt_regs based syscall calling for
>     IA32_EMULATION and x32
>   syscalls/x86: unconditionally enable struct pt_regs based syscalls on
>     x86_64
>   x86/entry/64: extend register clearing on syscall entry to lower
>     registers
>   syscalls/x86: rename struct pt_regs-based sys_*() to __sys_x86_*()
> 
> Linus Torvalds (1):
>   x86: don't pointlessly reload the system call number
> 
>  arch/x86/Kconfig                       |   1 +
>  arch/x86/entry/calling.h               |   2 +
>  arch/x86/entry/common.c                |  20 +-
>  arch/x86/entry/entry_64.S              |   3 +-
>  arch/x86/entry/entry_64_compat.S       |   6 +
>  arch/x86/entry/syscall_32.c            |  15 +-
>  arch/x86/entry/syscall_64.c            |   6 +-
>  arch/x86/entry/syscalls/syscall_32.tbl | 724 +++++++++++++++++----------------
>  arch/x86/entry/syscalls/syscall_64.tbl | 712 ++++++++++++++++----------------
>  arch/x86/entry/vsyscall/vsyscall_64.c  |  18 +-
>  arch/x86/include/asm/syscall.h         |   4 +
>  arch/x86/include/asm/syscall_wrapper.h | 197 +++++++++
>  arch/x86/include/asm/syscalls.h        |  17 +-
>  include/linux/compat.h                 |  22 +
>  include/linux/syscalls.h               |  25 +-
>  init/Kconfig                           |  10 +
>  kernel/sys_ni.c                        |  10 +
>  kernel/time/posix-stubs.c              |  10 +
>  18 files changed, 1054 insertions(+), 748 deletions(-)
>  create mode 100644 arch/x86/include/asm/syscall_wrapper.h

Ok, this series looks mostly good to me, but AFAICS this breaks the UML build:

 make[2]: *** No rule to make target 'archheaders'.  Stop.
 arch/um/Makefile:119: recipe for target 'archheaders' failed
 make[1]: *** [archheaders] Error 2
 make[1]: *** Waiting for unfinished jobs....

Thanks,

	Ingo